Conversation
-Search the string array instead of the directory -Remove m3u when importing games and m3u is not selected
Summary of ChangesHello @matthew-pye, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the game installation process by improving how M3U playlist files are handled. It ensures that M3U files are only considered and imported when explicitly enabled in the game mapping settings, and streamlines the detection of these files within the existing ROM file list. This leads to more accurate and user-setting-compliant game imports. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly refactors the M3U file handling logic during game installation. The changes improve efficiency by searching for M3U files within the already-retrieved list of ROM files instead of re-scanning the directory. The logic to handle cases where M3U is disabled is also more robust now. I have one suggestion to simplify a conditional check and align code formatting for better consistency.
2 participants
-Check UseM3u is enabled in the mapping before using it
-Remove m3u entry when importing games and m3u is not enabled
-Search the string array instead of the directory for m3u
31-01 07:49:35.890|INFO |RomM#RomMInstallController:Directory search took 1630 ticks31-01 07:49:35.890|INFO |RomM#RomMInstallController:actualRomFiles search took 324 ticks