Skip to content

Update platform_id to platform_ids#83

Merged
gantoine merged 1 commit intorommapp:mainfrom
matthew-pye:main
Jan 29, 2026
Merged

Update platform_id to platform_ids#83
gantoine merged 1 commit intorommapp:mainfrom
matthew-pye:main

Conversation

@matthew-pye
Copy link
Copy Markdown
Contributor

@matthew-pye matthew-pye commented Jan 29, 2026

Should fix #78

EDIT: Attach image to show no duplicates when importing
image

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @matthew-pye, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a crucial fix by updating an API parameter name from platform_id to platform_ids in the RomM.cs file. This change is intended to resolve issue #78, ensuring that the application correctly communicates with the API when retrieving game metadata based on platform identification.

Highlights

  • API Parameter Update: The platform_id parameter used in API requests within the GetGames method has been updated to platform_ids.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the API parameter name from platform_id to platform_ids in the GetGames method of RomM.cs. This change aligns with the expected API contract, as indicated by the pull request title and description, and should correctly address the issue mentioned in #78. The modification is a direct and focused correction to the parameter key.

@gantoine
Copy link
Copy Markdown
Member

nice catch!

@gantoine gantoine merged commit 205bd56 into rommapp:main Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] All Roms duplicated under all platforms

2 participants