Added download manager to inspect progress of games download#82
Added download manager to inspect progress of games download#82gantoine merged 4 commits intorommapp:mainfrom
Conversation
… moment I set a hardcoded limit of 10 concurrent downloads for performance reasons; we may increase it or leave it user defined in the future) We now are able to delete partial downloads when download was canceled for various reasons
Summary of ChangesHello @saitatter, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the game installation experience by introducing a comprehensive download manager. It centralizes the logic for downloading and extracting game files, offering better control over concurrent operations and ensuring proper cleanup in case of interruptions. Users will now benefit from a dedicated sidebar UI that provides real-time feedback on the progress of their game downloads, making the installation process more transparent and user-friendly. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a download manager to handle game downloads. While a great addition, it introduces two significant security vulnerabilities: a Critical Zip Slip vulnerability during archive extraction and a High-severity Path Traversal vulnerability during file download. These issues, stemming from insufficient sanitization of data from the RomM API (specifically filenames and archive entry paths), could allow a malicious server to overwrite arbitrary files on the user's system. It is highly recommended to sanitize all filenames using Path.GetFileName() and to validate archive entry paths before extraction. Additionally, a critical issue related to an infinite loop during file download needs fixing, and there are several suggestions for code cleanup and minor improvements.
|
Thanks @gantoine! Will sort them out this evening. |
2 participants
For the moment I set a hardcoded limit of 10 concurrent downloads for performance reasons; we may increase it or leave it user defined in the future)
We now are able to delete partial downloads when download was canceled for various reasons