Fix: Normalize RomMHost URLs to avoid double slashes#81
Fix: Normalize RomMHost URLs to avoid double slashes#81gantoine merged 7 commits intorommapp:mainfrom
Conversation
Summary of ChangesHello @saitatter, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a robust solution for constructing URLs within the application by centralizing URL combination logic. It prevents the creation of malformed URLs with redundant slashes, thereby improving the reliability of API calls and external links. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Update isMulti to HasMultipleFiles field
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new CombineUrl helper method to standardize URL construction and prevent double slashes, which is a good step towards improving code clarity and robustness. The new method is consistently applied throughout the file. My review includes a suggestion to make the new helper method safer against null inputs and points out a redundant line of code that can be removed.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a new CombineUrl method to normalize URLs and prevent double slashes, which is a good improvement for robustness. The code is also updated to use this new method, and a property has been renamed for better clarity. My review focuses on potential unhandled exceptions when the host URL is not configured. I've added a couple of suggestions to add guard clauses in FetchPlatforms and FetchRom methods to prevent the application from crashing, making the code more resilient.
2 participants
Added a new method which handles the trimming of ending / to avoid duplicate backslash when appending URIs.