fix: ensure rom installation paths are initialized correctly upon import#24
Merged
gantoine merged 1 commit intorommapp:mainfrom Sep 6, 2024
Merged
Conversation
Fixes rommapp#11 Ensures that paths are correctly initialized upon initial library imports. This makes this library plugin compatible with the Installation Status Updater plugin.
alextiley
changed the title
Member
This is bad practice for the romm app, the paths for n64 should look like this: Can you try using these paths for n64 games and report back? The code itself looks fine but I want to make sure the behaviour works as expected with proper platform mapping. |
Contributor
Author
|
Sure, I agree that the directory I'm using isn't correct; I'm potentially looking at migrating from EmuLibrary to this and just created a single folder during my exploratory testing. Will report back shortly. |
Contributor
Author
|
@gantoine Here you go, on a different machine this time but here's the same sort of thing with better directory path mappings:
|
gantoine
approved these changes
Sep 6, 2024
|
@gantoine Hate to ask, but any idea when this fix will be released? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12
Currently when roms are imported the installation path of each game is incorrectly set to the root destination path of the emulator path mapping. A rom entry is also created with another incorrect path - this path differs from the actual path that is later assigned upon rom install. This behavior conflicts with the Installation Status Updater plugin and causes all imported roms to be marked as installed if the root destination path contains at least one file at import time.
This PR ensures that both installation and rom paths are correctly initialized on initial library import. This fixes compatibility with the Installation Status Updater plugin.
Configured mappings:
Paths on import:
Paths post install:
