You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 2f98e24
Browse filesBrowse the repository at this point in the historyBrowse files
feat(issues): qualify a commit closer with its repository when it is not this one
A PR closer is written owner/name#N when it lives in another repository,
but a commit closer printed its abbreviated oid alone, so a commit in
another repository that closed the issue read as a commit in this one, on
the line the skill calls authoritative. The query now selects the commit's
repository and the line reads `by commit owner/name@<sha>` when it differs,
through the same case-insensitive comparison the PR form uses, now a shared
helper. A commit with no repository in the payload still reads as this one.
The query shape ran once against real gh on cli/cli#13898.
Finding O-Q4. Before the fix the new issue-closer-commit-crossrepo
fixture rendered "closed [dana …] as completed by commit 1a2b3c4"; the
golden now pins "by commit other/upstream@1a2b3c4".
Copy file name to clipboardExpand all lines: gh-comments
+11-5Lines changed: 11 additions & 5 deletions
Original file line number
Diff line number
Diff line change
@@ -445,7 +445,7 @@ ISSUE_FULL='number title state stateReason author{login __typename} createdAt bo
445
445
nodes{
446
446
__typename
447
447
... on IssueComment{author{login __typename} createdAt isMinimized minimizedReason body}
448
-
... on ClosedEvent{actor{login __typename} createdAt stateReason closer{__typename ... on PullRequest{number title state repository{nameWithOwner}} ... on Commit{abbreviatedOid}}}
448
+
... on ClosedEvent{actor{login __typename} createdAt stateReason closer{__typename ... on PullRequest{number title state repository{nameWithOwner}} ... on Commit{abbreviatedOid repository{nameWithOwner}}}}
449
449
... on ReopenedEvent{actor{login __typename} createdAt}
450
450
... on CrossReferencedEvent{actor{login __typename} createdAt willCloseTarget source{__typename ... on Issue{number title state repository{nameWithOwner}} ... on PullRequest{number title state repository{nameWithOwner}}}}
451
451
... on RenamedTitleEvent{actor{login __typename} createdAt previousTitle currentTitle}
0 commit comments