This repository was archived by the owner on Aug 4, 2021. It is now read-only.
Exclude typescript-helpers from source maps#64
Merged
TrySound merged 1 commit intorollup:masterfrom Aug 17, 2016
maxdavidson:hide-typescript-helpers
Merged
Exclude typescript-helpers from source maps#64TrySound merged 1 commit intorollup:masterfrom maxdavidson:hide-typescript-helpers
TrySound merged 1 commit intorollup:masterfrom
maxdavidson:hide-typescript-helpers
Conversation
| const sources = result.map.sources; | ||
|
|
||
| function isNotHelper( path ) { | ||
| return path.indexOf( 'typescript-helpers' ) === -1; |
Member
There was a problem hiding this comment.
Isn't it equal '\0typescript-helpers'?
Contributor
Author
There was a problem hiding this comment.
I was just checking that no source path in the generated source map includes the word typescript-helpers. That should cover both \0typescript-helpers and the path to typescript-helpers.js. It's not great, but gets the job done in this simple example.
Member
|
Thanks |
Member
|
Published 0.8.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61 by prefixing the typescript-helpers import with "\0". This makes it a virtual module, so we must inject it manually instead of just replacing the path.
This is how rollup-plugin-babel does it, see rollup/rollup-plugin-babel#64. It was implement in Rollup with rollup/rollup#747.