This repository was archived by the owner on Aug 4, 2021. It is now read-only.
Handle TypeScript's export class Name#18
Merged
Victorystick merged 5 commits intomasterfrom Jan 20, 2016
Merged
Conversation
Victorystick
added a commit
that referenced
this pull request
Jan 20, 2016
Handle TypeScript's `export class Name`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hack around TypeScript's broken handling of
export classwith ES6 modules and ES5 script target.It works because TypeScript transforms
into something like CommonJS, when we wanted ES6 modules.
But
is transformed into this beauty.
The solution is to replace the previous export syntax with the latter. The changes in this PR can be reverted once TypeScript supports this natively.
We also ensure that errors are reported for the current file.
Fixes #9
Includes #10