This repository was archived by the owner on Aug 4, 2021. It is now read-only.
Fix duplicate export error (e.g. when importing Cheerio)#230
Merged
lukastaegert merged 1 commit intorollup:masterfrom Oct 7, 2017
Merged
Fix duplicate export error (e.g. when importing Cheerio)#230lukastaegert merged 1 commit intorollup:masterfrom
lukastaegert merged 1 commit intorollup:masterfrom
Conversation
Member
|
Looks great, sorry to have kept you waiting 🎉 |
Contributor
Author
|
@lukastaegert Great, thank you! When could I expect the next release of rollup-plugin-commonjs? |
Member
|
Give me a few more minutes 😀 |
Member
|
Oh no, maybe I overestimated my powers here which only seem to extend to merging PRs put not to publishing new versions. I will PM @Rich-Harris as he will probably need to do this. |
Member
|
Until @Rich-Harris is back at the internet to publish a new version, you can install a version containing this fix via npm install github:rollup-plugin-commonjs@rollup/rollup-plugin-commonjs#bundled-v8.2.3which should contain all necessary build artefacts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rollup/rollup#1637
I've tried to follow @kzc's patch and test cases as closely as I could, but please let me know if I need to make any changes.
Thanks,
Caleb