Skip to content
This repository was archived by the owner on Aug 4, 2021. It is now read-only.
This repository was archived by the owner on Aug 4, 2021. It is now read-only.

es3 support #364

@sormy

Description

@sormy

Current version of plugin doesn't produce valid es3 code. This fix is easy. Let me know if you are open to accept this change and I will submit a PR (replace .default with ["default"]):

diff -ur rollup-plugin-commonjs/dist/rollup-plugin-commonjs.cjs.js rollup-plugin-commonjs.new/dist/rollup-plugin-commonjs.cjs.js
--- rollup-plugin-commonjs.old/dist/rollup-plugin-commonjs.cjs.js	1985-10-26 04:15:00.000000000 -0400
+++ rollup-plugin-commonjs.new/dist/rollup-plugin-commonjs.cjs.js	2018-10-27 00:04:53.000000000 -0400
@@ -13,7 +13,7 @@
 var EXTERNAL_PREFIX = '\0commonjs-external:';
 var HELPERS_ID = '\0commonjsHelpers';

-var HELPERS = "\nexport var commonjsGlobal = typeof window !== 'undefined' ? window : typeof global !== 'undefined' ? global : typeof self !== 'undefined' ? self : {};\n\nexport function commonjsRequire () {\n\tthrow new Error('Dynamic requires are not currently supported by rollup-plugin-commonjs');\n}\n\nexport function unwrapExports (x) {\n\treturn x && x.__esModule && Object.prototype.hasOwnProperty.call(x, 'default') ? x.default : x;\n}\n\nexport function createCommonjsModule(fn, module) {\n\treturn module = { exports: {} }, fn(module, module.exports), module.exports;\n}\n\nexport function getCjsExportFromNamespace (n) {\n\treturn n && n.default || n;\n}";
+var HELPERS = "\nexport var commonjsGlobal = typeof window !== 'undefined' ? window : typeof global !== 'undefined' ? global : typeof self !== 'undefined' ? self : {};\n\nexport function commonjsRequire () {\n\tthrow new Error('Dynamic requires are not currently supported by rollup-plugin-commonjs');\n}\n\nexport function unwrapExports (x) {\n\treturn x && x.__esModule && Object.prototype.hasOwnProperty.call(x, 'default') ? x['default'] : x;\n}\n\nexport function createCommonjsModule(fn, module) {\n\treturn module = { exports: {} }, fn(module, module.exports), module.exports;\n}\n\nexport function getCjsExportFromNamespace (n) {\n\treturn n && n['default'] || n;\n}";

 var isCjsPromises = Object.create(null);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions