Skip to content
This repository was archived by the owner on Aug 4, 2021. It is now read-only.
This repository was archived by the owner on Aug 4, 2021. It is now read-only.

Importing babelHelpers messes up source maps #64

@maxdavidson

Description

@maxdavidson

As of v2.5.0, the babel helpers are imported as the virtual file __babelHelpers__. This messes up the source maps, since the path is apparently resolved to the root directory. Reverting to v2.4.0 fixes this.

{"version":3,"file":null,"sources":["../src/symbol.ts","../src/defaults.ts","../../../../../__babelHelpers__","../src/utils.ts","../src/index.ts"], ... }

This is very noticeable when doing coverage reports that utilize the source maps to map back to the original source. It also downright breaks coveralls, since it seems to check that all sources actually exist on disk.

➜  dynamic-typed-array git:(master) ✗ npm run test:coveralls

> [email protected] test:coveralls /Users/maxdavidson/Developer/dynamic-typed-array
> cat coverage/lcov.info | coveralls

fs.js:634
  return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
                 ^

Error: ENOENT: no such file or directory, open '/__babelHelpers__'
    at Error (native)
    at Object.fs.openSync (fs.js:634:18)
    at Object.fs.readFileSync (fs.js:502:33)
    at convertLcovFileObject (/Users/maxdavidson/Developer/dynamic-typed-array/node_modules/coveralls/lib/convertLcovToCoveralls.js:18:18)
    at /Users/maxdavidson/Developer/dynamic-typed-array/node_modules/coveralls/lib/convertLcovToCoveralls.js:64:34
    at Array.forEach (native)
    at /Users/maxdavidson/Developer/dynamic-typed-array/node_modules/coveralls/lib/convertLcovToCoveralls.js:63:12
    at walkFile (/Users/maxdavidson/Developer/dynamic-typed-array/node_modules/lcov-parse/lib/index.js:103:9)
    at /Users/maxdavidson/Developer/dynamic-typed-array/node_modules/lcov-parse/lib/index.js:112:20
    at FSReqWrap.cb [as oncomplete] (fs.js:251:19)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions