Skip to content

Re-enable TypeScript test #6174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukastaegert merged 1 commit into from
Nov 10, 2025
Merged

Re-enable TypeScript test #6174

lukastaegert merged 1 commit into from
Nov 10, 2025
+4 −3

Conversation

@lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Nov 8, 2025

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

As part of the fix yesterday, I needed to disable the TypeScript test as it relied on patch-package working in the cached node_modules. This should re-enable it and also show us whether we need to invalidate some images.

@vercel
Copy link

vercel bot commented Nov 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rollup Ready Ready Preview Comment Nov 10, 2025 9:23am

@github-actions
Copy link

github-actions bot commented Nov 8, 2025 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix-ts-test

Notice: Ensure you have installed the latest nightly Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-gwtewiuta-rollup-js.vercel.app/repl/?pr=6174

@github-actions
Copy link

github-actions bot commented Nov 8, 2025 •
edited
Loading

Performance report

  • BUILD: 6964ms, 828 MB
    • initialize: 0ms, 24.6 MB (+7%)
    • generate module graph: 2611ms, 634 MB
      • generate ast: 1369ms, 623 MB
    • sort and bind modules: 399ms, 693 MB
    • mark included statements: 3933ms, 828 MB
      • treeshaking pass 1: 2318ms, 824 MB
      • treeshaking pass 2: 459ms, 821 MB
      • treeshaking pass 3: 393ms, 829 MB
      • treeshaking pass 4: 378ms, 818 MB
      • treeshaking pass 5: 374ms, 828 MB
  • GENERATE: 673ms, 923 MB
    • initialize render: 0ms, 828 MB
    • generate chunks: 45ms, 824 MB
      • optimize chunks: 0ms, 846 MB
    • render chunks: 610ms, 904 MB
    • transform chunks: 17ms, 923 MB
    • generate bundle: 0ms, 923 MB

@codecov
Copy link

codecov bot commented Nov 8, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.74%. Comparing base (d8b0150) to head (d746733).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6174   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         271      271           
  Lines       10639    10639           
  Branches     2847     2847           
=======================================
  Hits        10505    10505           
  Misses         91       91           
  Partials       43       43

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lukastaegert lukastaegert merged commit f0a80d1 into master Nov 10, 2025
46 checks passed
@lukastaegert lukastaegert deleted the fix-ts-test branch November 10, 2025 09:58
@github-actions
Copy link

github-actions bot commented Nov 19, 2025

This PR has been released as part of [email protected]. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lukastaegert