fix: move patch-package from postinstall to prepare script #6172
Conversation
In case patch-package is installed for development only, prepare script is more appropriate.
|
@mshima is attempting to deploy a commit to the rollup-js Team on Vercel. A member of the Team first needs to authorize it. |
mshima
changed the title
mshima
changed the title
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lukastaegert
left a comment
lukastaegert
left a comment
There was a problem hiding this comment.
So sorry, will release this asap
|
@lukastaegert this happens, and the work a round is so easy... |
|
So, pipeline is running, will take around 15-20 minutes to complete. And the thing, I remember really thinking about this but then messed up nonetheless. Maybe I should have actually read the docs one last time... |
|
Then again, maybe I just read the patch-package docs and did not think too much about them https://www.npmjs.com/package/patch-package |
|
@lukastaegert all good, really appreciate the quick fix here, especially since it's pretty late in the night in Germany 🙏 |
|
Thanks for the prompt fix, happy Friday! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6172 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 271 271
Lines 10639 10639
Branches 2847 2847
=======================================
Hits 10503 10503
Misses 91 91
Partials 45 45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add patch-package to prepare script In case patch-package is installed for development only, prepare script is more appropriate.
Add patch-package to prepare script In case patch-package is installed for development only, prepare script is more appropriate.
Add patch-package to prepare script In case patch-package is installed for development only, prepare script is more appropriate.
|
This PR has been released as part of [email protected]. You can test it via |
5 participants
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
In case patch-package is installed for development only, prepare script is more appropriate.
Otherwise patch-package should be moved from devDependencies to dependencies and this PR should be closed.