fix(native-loader): safely handle report.getReport() on Termux/Android #6123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Termux/Android, `report.getReport()` crashes because CPU information is not available in the environment, causing the native Rollup loader to throw `Failed to get cpu info`. This change wraps calls to `report.getReport()` in try/catch: - `isMusl()` now returns `false` if report information is unavailable, allowing Rollup to continue loading native bindings. - Windows MINGW detection (`isMingw32()`) is also safely wrapped. These changes are non-breaking and maintain existing behavior on supported platforms. They ensure Rollup can run on Termux/Android without crashing while preserving all existing bindings and error handling. No other logic is modified; this strictly improves environment robustness.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
lukastaegert
left a comment
lukastaegert
left a comment
There was a problem hiding this comment.
Thanks! Just minor comments, but this sounds like a good improvement.
lukastaegert
approved these changes
Sep 27, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6123 +/- ##
==========================================
- Coverage 98.73% 98.72% -0.02%
==========================================
Files 271 271
Lines 10630 10637 +7
Branches 2846 2846
==========================================
+ Hits 10496 10501 +5
- Misses 89 91 +2
Partials 45 45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR has been released as part of [email protected]. You can test it via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Termux/Android,
report.getReport()crashes because CPU information is not available in the environment, causing the native Rollup loader to throwFailed to get cpu info.This change wraps calls to
report.getReport()in try/catch:isMusl()now returnsfalseif report information is unavailable, allowing Rollup to continue loading native bindings.isMingw32()) is also safely wrapped.These changes are non-breaking and maintain existing behavior on supported platforms. They ensure Rollup can run on Termux/Android without crashing while preserving all existing bindings and error handling.
No other logic is modified; this strictly improves environment robustness.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description