Skip to content

Improve caching on CI#5772

Merged
lukastaegert merged 3 commits intomasterfrom
improve-ci-caching
Dec 27, 2024
Merged

Improve caching on CI#5772
lukastaegert merged 3 commits intomasterfrom
improve-ci-caching

Conversation

@lukastaegert
Copy link
Copy Markdown
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

As we are constantly running over the limits of our available cache storage, the goal is to only save caches from master and read them on branches/tags, and also to align cache keys between different jobs.

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 7:14pm

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 23, 2024

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#improve-ci-caching

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-fvcc93w32-rollup-js.vercel.app/repl/?pr=5772

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 23, 2024

Performance report

  • BUILD: 8103ms, 731 MB
    • initialize: 0ms, 26.6 MB
    • generate module graph: 3120ms, 553 MB
      • generate ast: 1501ms, 546 MB
    • sort and bind modules: 436ms, 596 MB
    • mark included statements: 4538ms, 731 MB
      • treeshaking pass 1: 1547ms, 695 MB
      • treeshaking pass 2: 738ms, 722 MB
      • treeshaking pass 3: 291ms, 725 MB
      • treeshaking pass 4: 271ms, 722 MB
      • treeshaking pass 5: 312ms, 729 MB
      • treeshaking pass 6: 257ms, 731 MB
      • treeshaking pass 7: 240ms, 728 MB
      • treeshaking pass 8: 235ms, 734 MB
      • treeshaking pass 9: 213ms, 736 MB
      • treeshaking pass 10: 215ms, 734 MB
      • treeshaking pass 11: 212ms, 731 MB
  • GENERATE: 880ms, 980 MB
    • initialize render: 0ms, 871 MB
    • generate chunks: 86ms, 878 MB
      • optimize chunks: 0ms, 873 MB
    • render chunks: 774ms, 957 MB
    • transform chunks: 18ms, 980 MB
    • generate bundle: 0ms, 980 MB

They can share the cache with the corresponding build jobs.
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (5d37778) to head (3817273).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5772   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files         259      259           
  Lines        8090     8090           
  Branches     1363     1363           
=======================================
  Hits         8010     8010           
  Misses         53       53           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert marked this pull request as ready for review December 27, 2024 19:32
@lukastaegert lukastaegert merged commit c54fb1b into master Dec 27, 2024
@lukastaegert lukastaegert deleted the improve-ci-caching branch December 27, 2024 19:32
@github-actions
Copy link
Copy Markdown

This PR has been released as part of [email protected]. Note that this is a pre-release, so to test it, you need to install Rollup via npm install [email protected] or npm install rollup@beta. It will likely become part of a regular release later.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 5, 2025

This PR has been released as part of [email protected]. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant