Skip to content

fix: introduce UnknownFalsyValue for enhancing if statement tree-shaking#5763

Merged
lukastaegert merged 2 commits intomasterfrom
fix/5744
Dec 20, 2024
Merged

fix: introduce UnknownFalsyValue for enhancing if statement tree-shaking#5763
lukastaegert merged 2 commits intomasterfrom
fix/5744

Conversation

@TrickyPi
Copy link
Copy Markdown
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #5744

Description

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 1:59am

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 15, 2024

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/5744

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-lvew2luuz-rollup-js.vercel.app/repl/?pr=5763

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 15, 2024

Performance report

  • BUILD: 8208ms, 731 MB
    • initialize: 0ms, 26.6 MB
    • generate module graph: 3083ms, 553 MB
      • generate ast: 1464ms, 546 MB
    • sort and bind modules: 451ms (+11ms, +2.4%), 596 MB
    • mark included statements: 4658ms, 731 MB
      • treeshaking pass 1: 1545ms, 695 MB
      • treeshaking pass 2: 756ms, 722 MB
      • treeshaking pass 3: 300ms, 725 MB
      • treeshaking pass 4: 280ms, 723 MB
      • treeshaking pass 5: 324ms, 730 MB
      • treeshaking pass 6: 267ms, 728 MB
      • treeshaking pass 7: 249ms, 729 MB
      • treeshaking pass 8: 243ms, 732 MB
      • treeshaking pass 9: 223ms, 734 MB
      • treeshaking pass 10: 225ms, 735 MB
      • treeshaking pass 11: 221ms, 731 MB
  • GENERATE: 904ms, 980 MB
    • initialize render: 0ms, 872 MB
    • generate chunks: 88ms, 876 MB
      • optimize chunks: 0ms, 875 MB
    • render chunks: 795ms, 958 MB
    • transform chunks: 18ms, 980 MB
    • generate bundle: 0ms, 980 MB

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (7a8ac46) to head (2eeecc9).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5763   +/-   ##
=======================================
  Coverage   99.00%   99.01%           
=======================================
  Files         258      259    +1     
  Lines        8072     8085   +13     
  Branches     1361     1362    +1     
=======================================
+ Hits         7992     8005   +13     
  Misses         53       53           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side, let me know when you are ready to merge.

@TrickyPi
Copy link
Copy Markdown
Member Author

No more changes from me. Feel free to merge!

@lukastaegert lukastaegert added this pull request to the merge queue Dec 20, 2024
Merged via the queue into master with commit d52f00d Dec 20, 2024
@lukastaegert lukastaegert deleted the fix/5744 branch December 20, 2024 06:40
@github-actions
Copy link
Copy Markdown

This PR has been released as part of [email protected]. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Order of logical typeof operands breaks tree-shaking

2 participants