extend more hooks to include import attributes and add warnings by TrickyPi · Pull Request #5700 · rollup/rollup

TrickyPi · 2024-10-24T13:02:01Z

This PR contains:

Are tests included?

yes (bugfixes and features will not be merged without tests)
no

Breaking Changes?

yes (breaking changes will not be merged unless absolutely necessary)
no

List any relevant issue numbers:
#5694

Description

Add the missing import attributes for the hooks load, transform and renderDynamicImport. For the upcoming breaking changes for complete resolving #5694, add a warning when returning attributes from load or transform with strictDeprecations enabled.
cc @sapphi-red , It would be appreciated to get your feedback on whether the API extensions are satisfactory for you.

vercel · 2024-10-24T13:02:05Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
rollup	Ready	Preview, Comment	Jan 26, 2026 5:27am

github-actions · 2024-10-24T13:04:41Z

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#feat/different-import-attributes

Notice: Ensure you have installed the latest nightly Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-kypahsyxn-rollup-js.vercel.app/repl/?pr=5700

github-actions · 2024-10-24T13:08:46Z

Performance report

BUILD: 6974ms, 836 MB
- initialize: 0ms, 24.6 MB (+7%)
- generate module graph: 2629ms, 634 MB
  - generate ast: 1386ms, 626 MB
- sort and bind modules: 412ms, 692 MB
- mark included statements: 3938ms, 836 MB
  - treeshaking pass 1: 2283ms, 832 MB
  - treeshaking pass 2: 467ms, 853 MB
  - treeshaking pass 3: 403ms, 834 MB
  - treeshaking pass 4: 388ms, 861 MB
  - treeshaking pass 5: 386ms, 836 MB
GENERATE: 697ms, 938 MB
- initialize render: 0ms, 836 MB
- generate chunks: 41ms, 852 MB
  - optimize chunks: 0ms, 844 MB
- render chunks: 638ms, 911 MB
- transform chunks: 17ms, 938 MB
- generate bundle: 0ms, 938 MB

codecov · 2024-10-24T13:15:17Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.83%. Comparing base (c519d82) to head (1697459).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5700   +/-   ##
=======================================
  Coverage   98.83%   98.83%           
=======================================
  Files         273      273           
  Lines       10692    10700    +8     
  Branches     2849     2854    +5     
=======================================
+ Hits        10567    10575    +8     
  Misses         82       82           
  Partials       43       43

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lukastaegert · 2024-10-27T06:03:52Z

In ResolveIdHook, do we also want to add importerAttributes separately?

TrickyPi · 2024-10-27T14:08:11Z

Yeah, I think it can be included in the options parameter, just like attributes.

lukastaegert

Looking through the code besides adding importerAttributes to ResolveIdHook, the only thing missing to release this from my side is to adapt the types on the website.

TrickyPi · 2024-10-28T05:47:06Z

the only thing missing to release this from my side is to adapt the types on the website

Yeah, I’ll update the website after adding importerAttributes.

jogibear9988 · 2025-09-25T04:42:20Z

Is there anything holding this back?
I use json and css imports in all of my projects, and would really love to see a bundler support them.

Copilot

Pull request overview

This PR extends the plugin API to include import attributes in the load, transform, and renderDynamicImport hooks, and adds deprecation warnings when plugins return attributes from load or transform hooks. This is part of the work towards supporting multiple modules with the same ID but different import attributes (#5694).

Changes:

Extended load, transform, shouldTransformCachedModule, resolveId, resolveDynamicImport, and renderDynamicImport hooks to include import attribute information
Added importerAttributes parameter to resolveId and resolveDynamicImport hooks to pass the import attributes of the importing module
Added deprecation warnings when attributes are returned from load or transform hooks with strictDeprecations enabled
Removed attributes field from SourceDescription return type in documentation (now passed as input parameter instead)

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`src/rollup/types.d.ts`	Updated type definitions for hooks to include `attributes` and `importerAttributes` parameters
`src/utils/transform.ts`	Added `attributes` parameter to transform hook and deprecation warning for returning attributes
`src/ModuleLoader.ts`	Extended load hook with attributes parameter, added deprecation warning, and threaded importerAttributes through resolution
`src/utils/resolveIdViaPlugins.ts`	Added `importerAttributes` parameter to resolveId plugin calls
`src/utils/resolveId.ts`	Threaded `importerAttributes` through resolveId function
`src/utils/PluginContext.ts`	Added `importerAttributes` to `this.resolve` context function
`src/ast/nodes/ImportExpression.ts`	Added `targetModuleAttributes` to renderDynamicImport hook options
`src/utils/urls.ts`	Added URL constants for load and transform hook documentation
`test/function/samples/extend-more-hooks-to-include-import-attributes/*`	Test coverage for new hook parameters including attributes and importerAttributes
`test/function/samples/deprecated/warn-for-load-and-transform/*`	Test for deprecation warnings when returning attributes from load/transform
`test/incremental/index.js`	Updated test expectations to include attributes in shouldTransformCachedModule
`docs/plugin-development/index.md`	Updated documentation for all affected hooks, removed attributes from SourceDescription return types

…icts Also, we needed to add the ssr attribute in the handlers that did not yet have options at all. The expectation is to revert this for Rollup 5. Luckily, we removed skipLibCheck at last to detect those.

lukastaegert

Sorry for ignoring this for far too long. This weekend I did another review. There are some small things I changed:

I also added attributes fields for the current module to resolveFileUrl and resolveImportMeta
There is now a small dedicated section about import attributes in the docs. Not sure we want to keep it, but the AI suggested it and it did not feel completely bananas. I needed to slightly rework its examples, though.
Recently, I did some changes to get rid of skipLibCheck in the TypeScript config. As we now also have Vite and Vitepress as dependencies, this highlighted some type conflicts with the Vite types. In order to avoid friction, I did some temporary changes to the types that I hope we can revert again for Rollup 5:
- Marked the provided "options" in the load and transform hook as optional even though they are always present.
- Added a fake optional ssr attribute to options. Otherwise, the TypeScript compiler would complain that the existing Vite options had nothin in common with the Rollup options.

In general, I would like to merge this the next days in order to get the Rollup 5 release going soon.

TrickyPi · 2026-01-27T02:50:45Z

Super excited that the Rollup 5 release is getting close!

Lukas, just to confirm — the implementation for supporting different import attributes follows the approach described in #5694 (comment), correct? If so, I’ll continue with the follow-up implementation once this PR is merged.

I’ve also submitted an MR to merge feat/use-with-by-default. As for feat/use-base36, my suggestion would be to land it last to minimize merge conflicts with master during the Rollup 5 release cycle.

lukastaegert · 2026-01-27T05:01:49Z

Glad you are on board!

follows the approach described in #5694 (comment),

As there has been no other word, I think we should just implement it that way, yes.

I’ll continue with the follow-up implementation once this PR is merged

Please do so!

github-actions · 2026-01-27T07:18:10Z

This PR has been released as part of [email protected]. You can test it via npm install rollup.

sapphi-red reviewed Oct 25, 2024

View reviewed changes

Comment thread src/rollup/types.d.ts Outdated

Comment thread src/rollup/types.d.ts

vercel Bot deployed to Preview October 25, 2024 14:27 View deployment

lukastaegert reviewed Oct 28, 2024

View reviewed changes

Comment thread test/function/samples/warn-for-load-and-transform/_config.js Outdated

TrickyPi force-pushed the feat/different-import-attributes branch from 62cb213 to f026169 Compare October 28, 2024 12:28

vercel Bot deployed to Preview October 28, 2024 12:31 View deployment

vercel Bot deployed to Preview October 28, 2024 15:19 View deployment

lukastaegert reviewed Oct 29, 2024

View reviewed changes

TrickyPi force-pushed the feat/different-import-attributes branch from bc9900b to 1652147 Compare October 29, 2024 14:45

vercel Bot deployed to Preview October 29, 2024 14:48 View deployment

TrickyPi mentioned this pull request Feb 17, 2025

Support import ... with {} syntax in the plugin pipeline #5847

Open

TrickyPi force-pushed the feat/different-import-attributes branch from 1652147 to 8e51d95 Compare March 9, 2025 07:51

vercel Bot deployed to Preview March 9, 2025 07:52 View deployment

TrickyPi force-pushed the feat/different-import-attributes branch from 8e51d95 to 196d1e1 Compare August 7, 2025 12:41

vercel Bot deployed to Preview August 7, 2025 12:43 View deployment

lukastaegert force-pushed the master branch 2 times, most recently from 5369863 to 96b5453 Compare November 7, 2025 21:32

TrickyPi added 5 commits January 25, 2026 07:00

extend more hooks to include import attributes and add warnings

dda8035

extend shouldTransformCachedModule hook to include attributes

058b2a8

add importerAttributes to ResolveIdHook

c89646c

update docs

2162bef

tweak docs

05a379f

Copilot AI review requested due to automatic review settings January 25, 2026 06:00

lukastaegert force-pushed the feat/different-import-attributes branch from 196d1e1 to 05a379f Compare January 25, 2026 06:00

vercel Bot deployed to Preview January 25, 2026 06:01 View deployment

Copilot started reviewing on behalf of lukastaegert January 25, 2026 06:03 View session

Copilot AI reviewed Jan 25, 2026

View reviewed changes

Comment thread src/ModuleLoader.ts Outdated

Comment thread src/utils/transform.ts Outdated

vercel Bot deployed to Preview January 25, 2026 07:29 View deployment

lukastaegert added 2 commits January 25, 2026 10:20

Use correct deprecation warning handler

48ba925

Mark some types as optional for now to avoid Vite and Vitepress confl…

72f0f92

…icts Also, we needed to add the ssr attribute in the handlers that did not yet have options at all. The expectation is to revert this for Rollup 5. Luckily, we removed skipLibCheck at last to detect those.

lukastaegert force-pushed the feat/different-import-attributes branch from 300a3a5 to 72f0f92 Compare January 25, 2026 09:20

vercel Bot deployed to Preview January 25, 2026 09:21 View deployment

lukastaegert added 2 commits January 25, 2026 13:35

Slightly extend documentation

06ce02e

Add attributes to resolveFileUrl and resolveImportMeta

1697459

vercel Bot deployed to Preview January 26, 2026 05:27 View deployment

lukastaegert approved these changes Jan 26, 2026

View reviewed changes

lukastaegert added this pull request to the merge queue Jan 27, 2026

Merged via the queue into master with commit 74121c7 Jan 27, 2026
48 checks passed

lukastaegert deleted the feat/different-import-attributes branch January 27, 2026 05:21

Uh oh!

Conversation

TrickyPi commented Oct 24, 2024

Description

Uh oh!

vercel Bot commented Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thank you for your contribution! ❤️

Uh oh!

github-actions Bot commented Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance report

Uh oh!

codecov Bot commented Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

lukastaegert commented Oct 27, 2024

Uh oh!

TrickyPi commented Oct 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lukastaegert left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TrickyPi commented Oct 28, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jogibear9988 commented Sep 25, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

lukastaegert left a comment

Choose a reason for hiding this comment

Uh oh!

TrickyPi commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lukastaegert commented Jan 27, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jan 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vercel Bot commented Oct 24, 2024 •

edited

Loading

github-actions Bot commented Oct 24, 2024 •

edited

Loading

github-actions Bot commented Oct 24, 2024 •

edited

Loading

codecov Bot commented Oct 24, 2024 •

edited

Loading

TrickyPi commented Oct 27, 2024 •

edited

Loading

TrickyPi commented Jan 27, 2026 •

edited

Loading