docs: steps to enable symlinks on windows#5134
Merged
lukastaegert merged 1 commit intorollup:masterfrom Sep 13, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
9 tasks
thebanjomatic
force-pushed
the
chore/symlink-contrib
branch
from
c3407fe to
8a20500
Compare
Codecov Report
@@ Coverage Diff @@
## master #5134 +/- ##
=======================================
Coverage 98.94% 98.94%
=======================================
Files 226 226
Lines 8429 8429
Branches 2314 2314
=======================================
Hits 8340 8340
Misses 32 32
Partials 57 57 |
lukastaegert
approved these changes
Sep 13, 2023
Member
lukastaegert
left a comment
lukastaegert
left a comment
There was a problem hiding this comment.
Thank you so much! As I cannot easily test on Windows, these kind of contributions are especially valuable!
|
This PR has been released as part of [email protected]. Note that this is a pre-release, so to test it, you need to install Rollup via |
Collaborator
|
This PR has been released as part of [email protected]. You can test it via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
I ran into issues running the tests on my windows machine, and it came down to git not being configured to create symlinks out of the box. I have updated the contributing guide to provide the additional steps required to be able to run the tests on windows.