Merged
Conversation
Otherwise, the created variable is not on the global object
This was referenced Jul 26, 2022
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#use-var-for-iifeor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4588 +/- ##
=======================================
Coverage 98.86% 98.86%
=======================================
Files 209 209
Lines 7344 7344
Branches 2098 2098
=======================================
Hits 7261 7261
Misses 27 27
Partials 56 56
Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, the created variable is not on the global object
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
iifeshould startsWithvarinstead ofconstevev if i set preset to es2015 #4585iifecode generated by vite3 is not working vitejs/vite#9318Description
IIFEs should not use
constto declare global variables. While it still works of sort because aconstdeclared in script scope is still visible in all scripts, it is not stored on the global object which will break flows that access the global object. Currently, this is only a problem when using thegeneratedCodeoption.