[v3.0] Remove actively deprecated features, show warnings for other deprecated features#4551
Merged
Merged
Conversation
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#remove-active-deprecationsor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4551 +/- ##
==========================================
- Coverage 98.89% 98.88% -0.01%
==========================================
Files 208 208
Lines 7332 7282 -50
Branches 2094 2081 -13
==========================================
- Hits 7251 7201 -50
Misses 26 26
Partials 55 55
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This removes the following deprecated features that were already showing warnings when used in Rollup 2:
this.emitAsset()this.emitChunk()this.getAssetFileName()this.getChunkFileName()this.isExternal()this.resolveId()resolveAssetUrlhook is removedassetReferenceIdor achunkReferenceIdparameter toresolveFileUrltreeshake.pureExternalModulesoption is removedisAssetflag in the bundletype: "asset"fieldOn the other hand, the following deprecated features will no show warnings when used:
inlineDynamicImportsas part of the input optionspreserveModulesas part of the input optionsmanualChunksas part of the input optionsoutput.preferConstoutput.dynamicImportFunctiontrueorfalseforoutput.interopoutput.namespaceToStringTagthis.moduleIdson the plugin contextthis.getModuleInfo(...).hasModuleSideEffectsin plugins