Closed
Conversation
This was referenced Jan 16, 2018
Merged
kellyselden
force-pushed
the
preserve-modules
branch
3 times, most recently
from
625d87c to
8191c61
Compare
Contributor
Author
|
@guybedford @lukastaegert Is there anything that can be done to alleviate the rebase of this once #1841 merges? |
kellyselden
force-pushed
the
preserve-modules
branch
from
8191c61 to
0eb8aae
Compare
Contributor
|
@kellyselden I'd suggest starting to try rebase on top of that branch on Rollup when you can, and sorry for the clash here. If you have any questions about getting this to work on top of that work (there may be some questions with the finalizers stuff), just let me know. |
kellyselden
force-pushed
the
preserve-modules
branch
from
0eb8aae to
12d863b
Compare
This was referenced Jan 20, 2018
Closed
kellyselden
force-pushed
the
preserve-modules
branch
from
12d863b to
f5ca865
Compare
added 2 commits
January 27, 2018 16:21
kellyselden
force-pushed
the
preserve-modules
branch
from
9423448 to
880eba1
Compare
Contributor
|
@kellyselden can this be closed now? |
Contributor
Author
|
Yep, superseded be #1922 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This still needs a lot of work, but I want to submit for feedback. I'm still working to submit chunks as small PRs, and cleanup and removed dead experiments. It is stable in my testing.
Motivation:
I would like to use rollup to tree-shake Ember.js apps. Ember.js has a module loader system that requires the files not be bundled into a single file.