fix: allow the name of Rollup Error to be modified (#5240)

TrickyPi · lukastaegert · web-flow · commit ef3be447cc1e · 2023-11-10T08:21:35.000Z
Co-authored-by: Lukas Taegert-Atkinson &lt;lukastaegert@users.noreply.github.com&gt;
diff --git a/src/utils/logs.ts b/src/utils/logs.ts
@@ -35,7 +35,7 @@ import {
 export function error(base: Error | RollupLog): never {
 	if (!(base instanceof Error)) {
 		base = Object.assign(new Error(base.message), base);
-		Object.defineProperty(base, 'name', { value: 'RollupError' });
+		Object.defineProperty(base, 'name', { value: 'RollupError', writable: true });
 	}
 	throw base;
 }
diff --git a/test/cli/samples/handles-uncaught-errors-under-watch/_config.js b/test/cli/samples/handles-uncaught-errors-under-watch/_config.js
@@ -0,0 +1,10 @@
+const { assertIncludes } = require('../../../utils.js');
+
+module.exports = defineTest({
+	description: 'handles uncaught errors under watch',
+	command: 'rollup --config rollup.config.js -w',
+	error: () => true,
+	stderr(stderr) {
+		assertIncludes(stderr, 'Uncaught RollupError: LOL');
+	}
+});
diff --git a/test/cli/samples/handles-uncaught-errors-under-watch/main.js b/test/cli/samples/handles-uncaught-errors-under-watch/main.js
@@ -0,0 +1 @@
+assert.equal( 42, 42 );
diff --git a/test/cli/samples/handles-uncaught-errors-under-watch/rollup.config.js b/test/cli/samples/handles-uncaught-errors-under-watch/rollup.config.js
@@ -0,0 +1,16 @@
+module.exports = {
+	input: 'main.js',
+	output: {
+		format: 'es'
+	},
+	plugins: [
+		{
+			name: 'test',
+			buildStart() {
+				Promise.resolve().then(() => {
+					this.error('LOL');
+				});
+			}
+		}
+	]
+};
diff --git a/test/types.d.ts b/test/types.d.ts
@@ -109,7 +109,7 @@ export interface TestConfigCli extends TestConfigBase {
 	 * Test the expected error. Assertions about the test output will only
 	 * be performed afterward if you return "true" or do not supply this option.
 	 */
-	error?: (error: RollupError) => boolean | void;
+	error?: (error: Error) => boolean | void;
 	/**
 	 * Execute the bundled code.
 	 */

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ import {`
`35`	`35`	`export function error(base: Error \| RollupLog): never {`
`36`	`36`	`if (!(base instanceof Error)) {`
`37`	`37`	`base = Object.assign(new Error(base.message), base);`
`38`		`- Object.defineProperty(base, 'name', { value: 'RollupError' });`
	`38`	`+ Object.defineProperty(base, 'name', { value: 'RollupError', writable: true });`
`39`	`39`	`}`
`40`	`40`	`throw base;`
`41`	`41`	`}`