fix: remove unnecessary property descriptor spread (#4403)

dnalborczyk · lukastaegert · web-flow · commit 69eb721ec1eb · 2022-02-14T05:52:53.000Z
* fix: remove unnecessary property descriptor spread

* Simplify import

Co-authored-by: Lukas Taegert-Atkinson &lt;lukas.taegert-atkinson@tngtech.com&gt;
Co-authored-by: Lukas Taegert-Atkinson &lt;lukastaegert@users.noreply.github.com&gt;
diff --git a/src/ExternalModule.ts b/src/ExternalModule.ts
@@ -73,7 +73,6 @@ export default class ExternalModule {
 		});
 		// Hide the deprecated key so that it only warns when accessed explicitly
 		Object.defineProperty(this.info, 'hasModuleSideEffects', {
-			...Object.getOwnPropertyDescriptor(this.info, 'hasModuleSideEffects'),
 			enumerable: false
 		});
 	}
diff --git a/src/Module.ts b/src/Module.ts
@@ -5,6 +5,7 @@ import MagicString from 'magic-string';
 import ExternalModule from './ExternalModule';
 import type Graph from './Graph';
 import { createHasEffectsContext, createInclusionContext } from './ast/ExecutionContext';
+import { nodeConstructors } from './ast/nodes';
 import ExportAllDeclaration from './ast/nodes/ExportAllDeclaration';
 import ExportDefaultDeclaration from './ast/nodes/ExportDefaultDeclaration';
 import type ExportNamedDeclaration from './ast/nodes/ExportNamedDeclaration';
@@ -17,7 +18,6 @@ import * as NodeType from './ast/nodes/NodeType';
 import Program from './ast/nodes/Program';
 import TemplateLiteral from './ast/nodes/TemplateLiteral';
 import VariableDeclaration from './ast/nodes/VariableDeclaration';
-import { nodeConstructors } from './ast/nodes/index';
 import type { ExpressionNode, NodeBase } from './ast/nodes/shared/Node';
 import ModuleScope from './ast/scopes/ModuleScope';
 import { type PathTracker, UNKNOWN_PATH } from './ast/utils/PathTracker';
@@ -335,7 +335,6 @@ export default class Module {
 		};
 		// Hide the deprecated key so that it only warns when accessed explicitly
 		Object.defineProperty(this.info, 'hasModuleSideEffects', {
-			...Object.getOwnPropertyDescriptor(this.info, 'hasModuleSideEffects'),
 			enumerable: false
 		});
 	}

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,6 @@ export default class ExternalModule {`
`73`	`73`	`});`
`74`	`74`	`// Hide the deprecated key so that it only warns when accessed explicitly`
`75`	`75`	`Object.defineProperty(this.info, 'hasModuleSideEffects', {`
`76`		`- ...Object.getOwnPropertyDescriptor(this.info, 'hasModuleSideEffects'),`
`77`	`76`	`enumerable: false`
`78`	`77`	`});`
`79`	`78`	`}`