Fix reassignment tracking (#4486)

lukastaegert · web-flow · commit 619563871dd7 · 2022-05-05T06:16:17.000+02:00
diff --git a/src/ast/variables/LocalVariable.ts b/src/ast/variables/LocalVariable.ts
@@ -155,7 +155,7 @@ export default class LocalVariable extends Variable {
 		if (path.length === 0) return false;
 		if (this.isReassigned) return true;
 		return (this.init &&
-			!context.accessed.trackEntityAtPathAndGetIfTracked(path, this) &&
+			!context.assigned.trackEntityAtPathAndGetIfTracked(path, this) &&
 			this.init.hasEffectsWhenAssignedAtPath(path, context))!;
 	}
 
diff --git a/test/function/samples/track-reassignments/_config.js b/test/function/samples/track-reassignments/_config.js
@@ -0,0 +1,3 @@
+module.exports = {
+	description: 'properly track reassignments (#4468)'
+};
diff --git a/test/function/samples/track-reassignments/main.js b/test/function/samples/track-reassignments/main.js
@@ -0,0 +1,15 @@
+import { patchEventTarget } from './patchEventTarget.js';
+
+class EventTarget {
+	addEventListener(callback) {
+		callback();
+	}
+}
+global.window = { EventTarget };
+
+let patchCalled = false;
+patchEventTarget(() => (patchCalled = true));
+const target = new EventTarget();
+target.addEventListener()
+
+assert.ok(patchCalled, 'patch');
diff --git a/test/function/samples/track-reassignments/patchEventTarget.js b/test/function/samples/track-reassignments/patchEventTarget.js
@@ -0,0 +1,10 @@
+export function patchEventTarget(callback) {
+	var proto = window.EventTarget.prototype;
+	var nativeAddEventListener = proto.addEventListener;
+
+	proto.addEventListener = function () {
+		return nativeAddEventListener(callback);
+	};
+
+	return proto;
+}

Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,7 @@ export default class LocalVariable extends Variable {`
`155`	`155`	`if (path.length === 0) return false;`
`156`	`156`	`if (this.isReassigned) return true;`
`157`	`157`	`return (this.init &&`
`158`		`- !context.accessed.trackEntityAtPathAndGetIfTracked(path, this) &&`
	`158`	`+ !context.assigned.trackEntityAtPathAndGetIfTracked(path, this) &&`
`159`	`159`	`this.init.hasEffectsWhenAssignedAtPath(path, context))!;`
`160`	`160`	`}`
`161`	`161`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+module.exports = {`
	`2`	`+ description: 'properly track reassignments (#4468)'`
	`3`	`+};`