disables optimization for external namespace when using the in operator (#6036)

TrickyPi · web-flow · commit 6031a33ea062 · 2025-07-28T04:13:28.000Z
diff --git a/src/ast/nodes/BinaryExpression.ts b/src/ast/nodes/BinaryExpression.ts
@@ -13,7 +13,7 @@ import {
 	UNKNOWN_PATH
 } from '../utils/PathTracker';
 import { getRenderedLiteralValue } from '../utils/renderLiteralValue';
-import type NamespaceVariable from '../variables/NamespaceVariable';
+import NamespaceVariable from '../variables/NamespaceVariable';
 import ExpressionStatement from './ExpressionStatement';
 import type { LiteralValue } from './Literal';
 import type * as NodeType from './NodeType';
@@ -105,10 +105,8 @@ export default class BinaryExpression extends NodeBase implements DeoptimizableE
 		if (typeof leftValue === 'symbol') return UnknownValue;
 
 		// Optimize `'export' in namespace`
-		if (this.operator === 'in' && this.right.variable?.isNamespace) {
-			return (
-				(this.right.variable as NamespaceVariable).context.traceExport(String(leftValue))[0] != null
-			);
+		if (this.operator === 'in' && this.right.variable instanceof NamespaceVariable) {
+			return this.right.variable.context.traceExport(String(leftValue))[0] != null;
 		}
 
 		const rightValue = this.right.getLiteralValueAtPath(EMPTY_PATH, recursionTracker, origin);
diff --git a/test/form/samples/external-namespace-optimzation-in-operator/_config.js b/test/form/samples/external-namespace-optimzation-in-operator/_config.js
@@ -0,0 +1,6 @@
+module.exports = {
+	description: 'disables optimization for external namespace when using the in operator',
+	options: {
+		external: ['node:crypto']
+	}
+};
diff --git a/test/form/samples/external-namespace-optimzation-in-operator/_expected.js b/test/form/samples/external-namespace-optimzation-in-operator/_expected.js
@@ -0,0 +1,5 @@
+import * as nc from 'node:crypto';
+
+const crypto = 'webcrypto' in nc;
+
+export { crypto };
diff --git a/test/form/samples/external-namespace-optimzation-in-operator/main.js b/test/form/samples/external-namespace-optimzation-in-operator/main.js
@@ -0,0 +1,2 @@
+import * as nc from 'node:crypto';
+export const crypto = 'webcrypto' in nc;

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+import * as nc from 'node:crypto';`
	`2`	`+export const crypto = 'webcrypto' in nc;`