Do not deoptimize entire super class when adding a property (#4489)

lukastaegert · web-flow · commit 47d8d5a53e1f · 2022-05-07T20:50:41.000+02:00
diff --git a/src/ast/nodes/shared/ObjectEntity.ts b/src/ast/nodes/shared/ObjectEntity.ts
@@ -128,7 +128,7 @@ export class ObjectEntity extends ExpressionEntity {
 			: this.allProperties) {
 			property.deoptimizePath(subPath);
 		}
-		this.prototypeExpression?.deoptimizePath(path.length === 1 ? [UnknownKey, UnknownKey] : path);
+		this.prototypeExpression?.deoptimizePath(path.length === 1 ? [...path, UnknownKey] : path);
 	}
 
 	deoptimizeThisOnEventAtPath(
diff --git a/test/form/samples/deoptimize-superclass/_config.js b/test/form/samples/deoptimize-superclass/_config.js
@@ -0,0 +1,3 @@
+module.exports = {
+	description: 'does not deoptimize the entire superclass when reassigning a property'
+};
diff --git a/test/form/samples/deoptimize-superclass/_expected.js b/test/form/samples/deoptimize-superclass/_expected.js
@@ -0,0 +1,2 @@
+// Everything else should be removed
+console.log('retained');
diff --git a/test/form/samples/deoptimize-superclass/main.js b/test/form/samples/deoptimize-superclass/main.js
@@ -0,0 +1,10 @@
+class Foo {}
+
+Foo.prototype.bar = {};
+
+class Bar extends Foo {}
+
+Bar.baz = {};
+
+// Everything else should be removed
+console.log('retained');

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ export class ObjectEntity extends ExpressionEntity {`
`128`	`128`	`: this.allProperties) {`
`129`	`129`	`property.deoptimizePath(subPath);`
`130`	`130`	`}`
`131`		`- this.prototypeExpression?.deoptimizePath(path.length === 1 ? [UnknownKey, UnknownKey] : path);`
	`131`	`+ this.prototypeExpression?.deoptimizePath(path.length === 1 ? [...path, UnknownKey] : path);`
`132`	`132`	`}`
`133`	`133`
`134`	`134`	`deoptimizeThisOnEventAtPath(`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+module.exports = {`
	`2`	`+ description: 'does not deoptimize the entire superclass when reassigning a property'`
	`3`	`+};`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+// Everything else should be removed`
	`2`	`+console.log('retained');`