refactor: use map for declarations and name suggestions (#4410)

dnalborczyk · web-flow · commit 213e721863c6 · 2022-02-20T15:02:22.000+01:00
* refactor: use map for declarations and name suggestions

* refactor: remove else condition

* refactor: remove additional lookup

* refactor: simplify condition
diff --git a/src/ExternalModule.ts b/src/ExternalModule.ts
@@ -13,15 +13,15 @@ import { printQuotedStringList } from './utils/printStringList';
 import relativeId from './utils/relativeId';
 
 export default class ExternalModule {
-	readonly declarations: { [name: string]: ExternalVariable } = Object.create(null);
+	readonly declarations = new Map<string, ExternalVariable>();
 	defaultVariableName = '';
 	readonly dynamicImporters: string[] = [];
 	execIndex = Infinity;
 	readonly exportedVariables = new Map<ExternalVariable, string>();
 	readonly importers: string[] = [];
 	readonly info: ModuleInfo;
 	mostCommonSuggestion = 0;
-	readonly nameSuggestions: { [name: string]: number } = Object.create(null);
+	readonly nameSuggestions = new Map<string, number>();
 	namespaceVariableName = '';
 	reexported = false;
 	renderPath: string = undefined as never;
@@ -78,12 +78,13 @@ export default class ExternalModule {
 	}
 
 	getVariableForExportName(name: string): [variable: ExternalVariable] {
-		let declaration = this.declarations[name];
+		const declaration = this.declarations.get(name);
 		if (declaration) return [declaration];
+		const externalVariable = new ExternalVariable(this, name);
 
-		this.declarations[name] = declaration = new ExternalVariable(this, name);
-		this.exportedVariables.set(declaration, name);
-		return [declaration];
+		this.declarations.set(name, externalVariable);
+		this.exportedVariables.set(externalVariable, name);
+		return [externalVariable];
 	}
 
 	setRenderPath(options: NormalizedOutputOptions, inputBase: string): string {
@@ -98,27 +99,28 @@ export default class ExternalModule {
 	}
 
 	suggestName(name: string): void {
-		if (!this.nameSuggestions[name]) this.nameSuggestions[name] = 0;
-		this.nameSuggestions[name] += 1;
+		const value = (this.nameSuggestions.get(name) ?? 0) + 1;
+		this.nameSuggestions.set(name, value);
 
-		if (this.nameSuggestions[name] > this.mostCommonSuggestion) {
-			this.mostCommonSuggestion = this.nameSuggestions[name];
+		if (value > this.mostCommonSuggestion) {
+			this.mostCommonSuggestion = value;
 			this.suggestedVariableName = name;
 		}
 	}
 
 	warnUnusedImports(): void {
-		const unused = Object.keys(this.declarations).filter(name => {
-			if (name === '*') return false;
-			const declaration = this.declarations[name];
-			return !declaration.included && !this.reexported && !declaration.referenced;
-		});
+		const unused = Array.from(this.declarations)
+			.filter(
+				([name, declaration]) =>
+					name !== '*' && !declaration.included && !this.reexported && !declaration.referenced
+			)
+			.map(([name]) => name);
+
 		if (unused.length === 0) return;
 
 		const importersSet = new Set<string>();
 		for (const name of unused) {
-			const { importers } = this.declarations[name].module;
-			for (const importer of importers) {
+			for (const importer of this.declarations.get(name)!.module.importers) {
 				importersSet.add(importer);
 			}
 		}
diff --git a/src/Module.ts b/src/Module.ts
@@ -527,11 +527,10 @@ export default class Module {
 			if (name.length === 1) {
 				// export * from './other'
 				return [this.namespace];
-			} else {
-				// export * from 'external'
-				const module = this.graph.modulesById.get(name.slice(1)) as ExternalModule;
-				return module.getVariableForExportName('*');
 			}
+			// export * from 'external'
+			const module = this.graph.modulesById.get(name.slice(1)) as ExternalModule;
+			return module.getVariableForExportName('*');
 		}
 
 		// export { foo } from './other'

Original file line number	Diff line number	Diff line change
`@@ -527,11 +527,10 @@ export default class Module {`
`527`	`527`	`if (name.length === 1) {`
`528`	`528`	`// export * from './other'`
`529`	`529`	`return [this.namespace];`
`530`		`- } else {`
`531`		`- // export * from 'external'`
`532`		`- const module = this.graph.modulesById.get(name.slice(1)) as ExternalModule;`
`533`		`- return module.getVariableForExportName('*');`
`534`	`530`	`}`
	`531`	`+ // export * from 'external'`
	`532`	`+ const module = this.graph.modulesById.get(name.slice(1)) as ExternalModule;`
	`533`	`+ return module.getVariableForExportName('*');`
`535`	`534`	`}`
`536`	`535`
`537`	`536`	`// export { foo } from './other'`