Also remove export-all declarations when not tree-shaking (#3209)

lukastaegert · web-flow · commit 066620ee487e · 2019-10-31T20:28:36.000+01:00
diff --git a/src/ast/nodes/ExportAllDeclaration.ts b/src/ast/nodes/ExportAllDeclaration.ts
@@ -1,8 +1,11 @@
+import MagicString from 'magic-string';
+import { NodeRenderOptions, RenderOptions } from '../../utils/renderHelpers';
 import Literal from './Literal';
 import * as NodeType from './NodeType';
 import { NodeBase } from './shared/Node';
 
 export default class ExportAllDeclaration extends NodeBase {
+	needsBoundaries!: true;
 	source!: Literal<string>;
 	type!: NodeType.tExportAllDeclaration;
 
@@ -13,4 +16,13 @@ export default class ExportAllDeclaration extends NodeBase {
 	initialise() {
 		this.context.addExport(this);
 	}
+
+	render(code: MagicString, _options: RenderOptions, nodeRenderOptions?: NodeRenderOptions) {
+		code.remove(
+			(nodeRenderOptions as NodeRenderOptions).start as number,
+			(nodeRenderOptions as NodeRenderOptions).end as number
+		);
+	}
 }
+
+ExportAllDeclaration.prototype.needsBoundaries = true;
diff --git a/test/form/samples/no-treeshake/_expected/amd.js b/test/form/samples/no-treeshake/_expected/amd.js
@@ -47,6 +47,7 @@ define(['exports', 'external'], function (exports, external) { 'use strict';
 
 	exports.create = create;
 	exports.getPrototypeOf = getPrototypeOf;
+	exports.quux = quux;
 	exports.strange = quux;
 
 	Object.defineProperty(exports, '__esModule', { value: true });
diff --git a/test/form/samples/no-treeshake/_expected/cjs.js b/test/form/samples/no-treeshake/_expected/cjs.js
@@ -51,4 +51,5 @@ test({
 
 exports.create = create;
 exports.getPrototypeOf = getPrototypeOf;
+exports.quux = quux;
 exports.strange = quux;
diff --git a/test/form/samples/no-treeshake/_expected/es.js b/test/form/samples/no-treeshake/_expected/es.js
@@ -45,4 +45,4 @@ test({
 	}
 });
 
-export { create, getPrototypeOf, quux as strange };
+export { create, getPrototypeOf, quux, quux as strange };
diff --git a/test/form/samples/no-treeshake/_expected/iife.js b/test/form/samples/no-treeshake/_expected/iife.js
@@ -48,6 +48,7 @@ var stirred = (function (exports, external) {
 
 	exports.create = create;
 	exports.getPrototypeOf = getPrototypeOf;
+	exports.quux = quux;
 	exports.strange = quux;
 
 	return exports;
diff --git a/test/form/samples/no-treeshake/_expected/umd.js b/test/form/samples/no-treeshake/_expected/umd.js
@@ -51,6 +51,7 @@
 
 	exports.create = create;
 	exports.getPrototypeOf = getPrototypeOf;
+	exports.quux = quux;
 	exports.strange = quux;
 
 	Object.defineProperty(exports, '__esModule', { value: true });
diff --git a/test/form/samples/no-treeshake/main.js b/test/form/samples/no-treeshake/main.js
@@ -1,6 +1,8 @@
 import * as external from 'external';
 import foo from './foo.js';
+
 export { quux as strange } from './quux.js';
+export * from './quux.js';
 
 function baz() {
 	return foo + external.value;

Original file line number	Diff line number	Diff line change
`@@ -45,4 +45,4 @@ test({`
`45`	`45`	`}`
`46`	`46`	`});`
`47`	`47`
`48`		`-export { create, getPrototypeOf, quux as strange };`
	`48`	`+export { create, getPrototypeOf, quux, quux as strange };`