chore(replace): run prettier on changelog#958
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your PR title doesn't match the required format. The title should be in the conventional commit (https://www.conventionalcommits.org/en/v1.0.0-beta.4/) format. e.g.
chore(plugin-name): add pr title workflow
tjenkinson
changed the title
|
I'm actually more in favor of removing the check. It's incredibly annoying for automation. Prettier will be run on any files modified in the release commit, including Changelings, and automatically committed. |
|
I think it's useful to have the catch-all, but we could exclude those auto generated files from prettier in the |
|
Having these files in prettierignore makes sense to me. Also moving prettier to the release process only sounds like a potential way around these issues in future as well. But given this is holding up all PRs right now, I'm all for merging the quickest fix here for now. |
|
Having a new line at the end of files also seems to be a good practice though (github also shows warnings), although I must admit I'm not sure why |
|
@guybedford when you're merging PRs, please make sure you're double checking the commit message that Github suggests to use. If the PR was created with a title that wasn't conventional commit style, and we update that title later, the suggested commit is typically the original non-compliant title. |
3 participants
Rollup Plugin Name:
replaceThis PR contains:
Are tests included?
Breaking Changes?
Description
Prettier is failing because of this missing newline, and therefore blocking the checks on #921
A fix might be needed in the publish script to ensure a new line at the end of the file.