fix(url): Conform to Rollup type definitions.#433
Merged
shellscape merged 2 commits intorollup:masterfrom Jun 5, 2020
seivan:patch-1
Merged
fix(url): Conform to Rollup type definitions.#433shellscape merged 2 commits intorollup:masterfrom seivan:patch-1
shellscape merged 2 commits intorollup:masterfrom
seivan:patch-1
Conversation
Also, exporting `defaultInclude` as I'd like to extend the defaults instead of redefining them.
NotWoods
approved these changes
Jun 3, 2020
shellscape
approved these changes
Jun 5, 2020
LarsDenBakker
pushed a commit
to LarsDenBakker/plugins
that referenced
this pull request
Sep 12, 2020
* Conform to Rollup type definitions. Also, exporting `defaultInclude` as I'd like to extend the defaults instead of redefining them. * Update index.js
franklx
pushed a commit
to franklx/rollup-plugin-url-emit
that referenced
this pull request
Sep 28, 2020
* Conform to Rollup type definitions. Also, exporting `defaultInclude` as I'd like to extend the defaults instead of redefining them. * Update index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
urlThis PR contains:
Are tests included?
Breaking Changes?
Description
Conform to Rollup type definitions to silence compiler errors, as they expect a plugin name and it's expected/advised on the docs.
Current workaround is:
or more succinct and error prone:
Also, exporting defaultInclude as I'd like to extend the defaults instead of redefining them.Edit: Got rid of that, since I guess you don't want to mix default and named export, understandable.