fix(node-resolve): handle nested entry modules with the resolveOnly option#430
Merged
shellscape merged 1 commit intomasterfrom Jun 1, 2020
Merged
fix(node-resolve): handle nested entry modules with the resolveOnly option#430shellscape merged 1 commit intomasterfrom
shellscape merged 1 commit intomasterfrom
Conversation
shellscape
approved these changes
Jun 1, 2020
LarsDenBakker
pushed a commit
to LarsDenBakker/plugins
that referenced
this pull request
Sep 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
node-resolveThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
resolves rollup/rollup#3610
Description
When a nested entry, e.g.
lib/main.js, is used with theresolveOnlyoption, it assumes it is a sub-path of thelibpackage and marks the entry as external. This is fixed here by checking if the actual importee is an entry.