feat(json): log the filename when JSON.parse fails#417
Merged
shellscape merged 1 commit intorollup:masterfrom Jun 3, 2020
Merged
feat(json): log the filename when JSON.parse fails#417shellscape merged 1 commit intorollup:masterfrom
shellscape merged 1 commit intorollup:masterfrom
Conversation
bennypowers
force-pushed
the
patch-1
branch
2 times, most recently
from
78db740 to
0d3c00e
Compare
shellscape
reviewed
May 26, 2020
bennypowers
force-pushed
the
patch-1
branch
2 times, most recently
from
795fbcb to
0efe962
Compare
Contributor
Author
|
This should be ready to go now |
shellscape
approved these changes
May 27, 2020
Collaborator
shellscape
left a comment
shellscape
left a comment
There was a problem hiding this comment.
This is good for this PR, but before we publish this change I want to utilize a custom error class and do some more maintenance on this plugin. Changing Error expectations means a major version, so it's a good time to tackle that.
shellscape
requested review from
Andarist,
LarsDenBakker,
NotWoods,
TrySound,
btd and
danielgindi
shellscape
reviewed
Jun 1, 2020
packages/json/src/index.js
Outdated
| } catch (err) { | ||
| const error = new Error(`Could not parse ${id}`); | ||
| error.originalError = err; | ||
| throw error; |
Collaborator
There was a problem hiding this comment.
I sat on this for a while and I'm glad that I did. I'd like to see this use this.warn rather than throwing the error.
shellscape
requested changes
Jun 1, 2020
Helpful when debugging Sometimes in a large codebase, a single comma buried in a gigantic json file can halt the entire build. This change ensures that users will more easily be able to find and fix those errors.
TrySound
approved these changes
Jun 3, 2020
shellscape
approved these changes
Jun 3, 2020
Collaborator
|
|
LarsDenBakker
pushed a commit
to LarsDenBakker/plugins
that referenced
this pull request
Sep 12, 2020
Helpful when debugging Sometimes in a large codebase, a single comma buried in a gigantic json file can halt the entire build. This change ensures that users will more easily be able to find and fix those errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
jsonThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
Helpful when debugging
Sometimes in a large codebase, a single comma buried in a gigantic json file can halt the entire build. This change ensures that users will more easily be able to find and fix those errors.