namedExports is now deprecated#410
Merged
shellscape merged 1 commit intorollup:masterfrom May 29, 2020
JounQin:patch-1
Merged
Conversation
Collaborator
|
Please add a thorough description to PRs. We won't consider PRs unless all fields have been properly filled out. |
Contributor
Author
|
OK, I just thought the commit message was fair enough. |
9 tasks
|
Yes, I'm also frustrated to land here & see this merged with such a sparse description, and without updating docs. I cannot build my project at all right now :( |
Collaborator
|
@joshribakoff while it stinks when stuff doesn't work, please do try to avoid venting frustrations by cross posting. If you believe that there's a bug with this plugin, please open a new bug issue (and pay close attention to the issue template - we're big on minimal reproductions). We're locking this one for now, since the PR is merged and this is attracting follow-up comments that are better served as issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
commonjsThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
As the commit message,
namedExportsoption of@rollup/plugin-commonjsis deprecated, so remove it from related types.