fix(commonjs): Only proxy detected commonjs entry points#1180
Merged
lukastaegert merged 2 commits intomasterfrom Jun 24, 2022
Merged
fix(commonjs): Only proxy detected commonjs entry points#1180lukastaegert merged 2 commits intomasterfrom
lukastaegert merged 2 commits intomasterfrom
Conversation
|
NB: Node.js v12 went EOL today, maybe remove it and introduce v17 as it goes LTS tomorrow?
|
lukastaegert
force-pushed
the
commonjs/reduce-entry-proxying
branch
from
92d8600 to
97b2f2e
Compare
shellscape
approved these changes
Jun 10, 2022
haoqunjiang
added a commit
to haoqunjiang/vite
that referenced
this pull request
Jun 23, 2022
Well, the built bundle doesn't work yet. Blocked by rollup/plugins#1180
Contributor
|
I can confirm that this PR fixes most issues that prevent Vite from updating the commonjs plugin. Before patching with this fix, most test cases in Vite fail (likely due to this bug interfering with the default |
9 tasks
Member
Author
|
I will ensure it is released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
commonjsThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Resolves #1169
Description
This will ease the issue in #1169 by only proxying detected CommonJS entry points (and not just every entry point). It does so via:
include/excludefiltering mechanismThus if you do not have commonjs entry points, you should no longer see the
?entry-proxymodules replacing your entry points.