feat(node-resolve): preserve search params and hashes (#487)

LarsDenBakker · web-flow · commit ec92d34241b0 · 2020-07-12T16:05:51.000-04:00
diff --git a/packages/node-resolve/src/index.js b/packages/node-resolve/src/index.js
@@ -90,6 +90,12 @@ export function nodeResolve(opts = {}) {
       // ignore IDs with null character, these belong to other plugins
       if (/\0/.test(importee)) return null;
 
+      // strip hash and query params from import
+      const [withoutHash, hash] = importee.split('#');
+      const [importPath, params] = withoutHash.split('?');
+      const importSuffix = `${params ? `?${params}` : ''}${hash ? `#${hash}` : ''}`;
+      importee = importPath;
+
       const basedir = !importer || dedupe(importee) ? rootDir : dirname(importer);
 
       // https://github.com/defunctzombie/package-browser-field-spec
@@ -244,11 +250,17 @@ export function nodeResolve(opts = {}) {
         if (resolved && options.modulesOnly) {
           const code = await readFile(resolved, 'utf-8');
           if (isModule(code)) {
-            return { id: resolved, moduleSideEffects: hasModuleSideEffects(resolved) };
+            return {
+              id: `${resolved}${importSuffix}`,
+              moduleSideEffects: hasModuleSideEffects(resolved)
+            };
           }
           return null;
         }
-        const result = { id: resolved, moduleSideEffects: hasModuleSideEffects(resolved) };
+        const result = {
+          id: `${resolved}${importSuffix}`,
+          moduleSideEffects: hasModuleSideEffects(resolved)
+        };
         return result;
       } catch (error) {
         return null;
diff --git a/packages/node-resolve/test/fixtures/hash.js b/packages/node-resolve/test/fixtures/hash.js
@@ -0,0 +1,3 @@
+import test from 'test#foo';
+
+export default test;
diff --git a/packages/node-resolve/test/fixtures/search-params-and-hash.js b/packages/node-resolve/test/fixtures/search-params-and-hash.js
@@ -0,0 +1,3 @@
+import test from 'test?foo=bar&lorem=ipsum#foo';
+
+export default test;
diff --git a/packages/node-resolve/test/fixtures/search-params.js b/packages/node-resolve/test/fixtures/search-params.js
@@ -0,0 +1,3 @@
+import test from 'test?foo=bar&lorem=ipsum';
+
+export default test;
diff --git a/packages/node-resolve/test/test.js b/packages/node-resolve/test/test.js
@@ -239,3 +239,78 @@ test('handles package side-effects', async (t) => {
 
   delete global.sideEffects;
 });
+
+test('can resolve imports with hashes', async (t) => {
+  const bundle = await rollup({
+    input: 'hash.js',
+    onwarn: () => t.fail('No warnings were expected'),
+    plugins: [
+      nodeResolve(),
+      {
+        load(id) {
+          if (id === resolve(__dirname, 'fixtures', 'node_modules', 'test', 'index.js#foo')) {
+            return 'export default "resolved with hash"';
+          }
+          return null;
+        }
+      }
+    ]
+  });
+  const { module } = await testBundle(t, bundle);
+
+  t.is(module.exports, 'resolved with hash');
+});
+
+test('can resolve imports with search params', async (t) => {
+  const bundle = await rollup({
+    input: 'search-params.js',
+    onwarn: () => t.fail('No warnings were expected'),
+    plugins: [
+      nodeResolve(),
+      {
+        load(id) {
+          if (
+            id ===
+            resolve(__dirname, 'fixtures', 'node_modules', 'test', 'index.js?foo=bar&lorem=ipsum')
+          ) {
+            return 'export default "resolved with search params"';
+          }
+          return null;
+        }
+      }
+    ]
+  });
+  const { module } = await testBundle(t, bundle);
+
+  t.is(module.exports, 'resolved with search params');
+});
+
+test('can resolve imports with search params and hash', async (t) => {
+  const bundle = await rollup({
+    input: 'search-params-and-hash.js',
+    onwarn: () => t.fail('No warnings were expected'),
+    plugins: [
+      nodeResolve(),
+      {
+        load(id) {
+          if (
+            id ===
+            resolve(
+              __dirname,
+              'fixtures',
+              'node_modules',
+              'test',
+              'index.js?foo=bar&lorem=ipsum#foo'
+            )
+          ) {
+            return 'export default "resolved with search params and hash"';
+          }
+          return null;
+        }
+      }
+    ]
+  });
+  const { module } = await testBundle(t, bundle);
+
+  t.is(module.exports, 'resolved with search params and hash');
+});

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+import test from 'test#foo';`
	`2`	`+`
	`3`	`+export default test;`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+import test from 'test?foo=bar&lorem=ipsum#foo';`
	`2`	`+`
	`3`	`+export default test;`