feat(node-resolve): support node: protocol (#1124)

isker · web-flow · commit a7b56eb5c818 · 2022-05-02T08:18:31.000-04:00
Imports with the [`node:` protocol](https://nodejs.org/api/esm.html#node-imports) are currently undetected by this plugin. Switch to using [is-builtin-module](https://github.com/sindresorhus/is-builtin-module), which handles this protocol and also submodule imports like `fs/promises`. Functionality is otherwise identical. Resolves #1120.
diff --git a/packages/node-resolve/package.json b/packages/node-resolve/package.json
@@ -57,8 +57,8 @@
   "dependencies": {
     "@rollup/pluginutils": "^3.1.0",
     "@types/resolve": "1.17.1",
-    "builtin-modules": "^3.1.0",
     "deepmerge": "^4.2.2",
+    "is-builtin-module": "^3.1.0",
     "is-module": "^1.0.0",
     "resolve": "^1.19.0"
   },
diff --git a/packages/node-resolve/src/index.js b/packages/node-resolve/src/index.js
@@ -1,7 +1,7 @@
 /* eslint-disable no-param-reassign, no-shadow, no-undefined */
 import { dirname, normalize, resolve, sep } from 'path';
 
-import builtinList from 'builtin-modules';
+import isBuiltinModule from 'is-builtin-module';
 import deepMerge from 'deepmerge';
 import isModule from 'is-module';
 
@@ -13,7 +13,6 @@ import { fileExists, readFile, realpath } from './fs';
 import resolveImportSpecifiers from './resolveImportSpecifiers';
 import { getMainFields, getPackageName, normalizeInput } from './util';
 
-const builtins = new Set(builtinList);
 const ES6_BROWSER_EMPTY = '\0node-resolve:empty.js';
 const deepFreeze = (object) => {
   Object.freeze(object);
@@ -172,7 +171,7 @@ export function nodeResolve(opts = {}) {
       ignoreSideEffectsForRoot
     });
 
-    const importeeIsBuiltin = builtins.has(importee);
+    const importeeIsBuiltin = isBuiltinModule(importee);
     const resolved =
       importeeIsBuiltin && preferBuiltins
         ? {
diff --git a/packages/node-resolve/test/fixtures/node-protocol.js b/packages/node-resolve/test/fixtures/node-protocol.js
@@ -0,0 +1 @@
+import 'node:fs';
diff --git a/packages/node-resolve/test/prefer-builtins.js b/packages/node-resolve/test/prefer-builtins.js
@@ -103,3 +103,16 @@ test('does not warn when using a builtin module when there is no local version,
 
   t.is(warning, null);
 });
+
+test('detects builtins imported with node: protocol', async (t) => {
+  const warnings = [];
+  await rollup({
+    input: 'node-protocol.js',
+    onwarn({ message }) {
+      warnings.push(message);
+    },
+    plugins: [nodeResolve()]
+  });
+
+  t.is(warnings.length, 0);
+});
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
