Conversation
…ogether These two options are mutually exclusive: skipNodeModulesBundle means "do not bundle any node_modules", while noExternal means "force certain dependencies to be bundled". Using them together leads to ambiguous behavior where transitive dependencies of noExternal packages are still externalized. Closes #741
✅ Deploy Preview for tsdown ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
|
Hey, I think this change is kind of breaking! |
Member
Author
|
@dackmin Please open a new issue describing the problem you encountered in detail, and provide a minimal reproduction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeErrorwhenskipNodeModulesBundleandnoExternalare both configured, as they are mutually exclusive optionsContext
skipNodeModulesBundlemeans "do not bundle any dependencies from node_modules", whilenoExternalmeans "force certain dependencies to be bundled". Using them together leads to ambiguous behavior where transitive dependencies ofnoExternalpackages are still externalized byskipNodeModulesBundle.Closes #741