fix(exports): correctly generate export paths for nested index files#559
Merged
sxzz merged 5 commits intorolldown:mainfrom Oct 26, 2025
Merged
fix(exports): correctly generate export paths for nested index files#559sxzz merged 5 commits intorolldown:mainfrom
sxzz merged 5 commits intorolldown:mainfrom
Conversation
✅ Deploy Preview for tsdown ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
…nto fix-nested-subpackage-exports
sxzz
reviewed
Oct 24, 2025
src/features/exports.ts
Outdated
| chunk.type === 'chunk' && | ||
| chunk.isEntry && | ||
| !RE_DTS.test(chunk.fileName), | ||
| !RE_DTS.test(slash(chunk.fileName)), |
Member
There was a problem hiding this comment.
This line can be reverted, since suffix name is the same in both Windows and Linux.
sxzz
approved these changes
Oct 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fix normalizes entrypoint paths to correctly handle subpackage exports, especially for nested index files and paths generated on Windows.
Linked Issues
resolves #558
Additional context
After updating my fork, on my local there are 3/4 tests failing: env and shims related to define/inject changes at Rolldown