feat(migrate): migrate external/noExternal to deps namespace

sxzz · sxzz · commit c59e797e9d9e · 2026-02-11T21:37:43.000+08:00
diff --git a/packages/migrate/src/helpers/__snapshots__/tsup-config.test.ts.snap b/packages/migrate/src/helpers/__snapshots__/tsup-config.test.ts.snap
@@ -74,6 +74,43 @@ exports[`default values > should not add format when present > code 1`] = `
 }"
 `;
 
+exports[`deps namespace migrations > external should move to deps.neverBundle > code 1`] = `
+"export default {
+  deps: {
+    neverBundle: ['foo', 'bar'],
+  },
+  format: 'cjs',
+  clean: false,
+  dts: false,
+  target: false,
+}"
+`;
+
+exports[`deps namespace migrations > multiple deps options should merge into single deps object > code 1`] = `
+"export default {
+  deps: {
+    neverBundle: ['foo'],
+    alwaysBundle: ['bar'],
+  },
+  format: 'cjs',
+  clean: false,
+  dts: false,
+  target: false,
+}"
+`;
+
+exports[`deps namespace migrations > noExternal should move to deps.alwaysBundle > code 1`] = `
+"export default {
+  deps: {
+    alwaysBundle: ['foo'],
+  },
+  format: 'cjs',
+  clean: false,
+  dts: false,
+  target: false,
+}"
+`;
+
 exports[`option transformations > bundle: false should transform to unbundle: true > code 1`] = `
 "export default {
   unbundle: true,
diff --git a/packages/migrate/src/helpers/tsup-config.test.ts b/packages/migrate/src/helpers/tsup-config.test.ts
@@ -119,6 +119,47 @@ describe('option transformations', () => {
   })
 })
 
+describe('deps namespace migrations', () => {
+  test('external should move to deps.neverBundle', () => {
+    const input = `
+      export default {
+        external: ['foo', 'bar'],
+      }
+    `
+    const { code } = transform(input, 'tsup.config.ts')
+    expect(code).toContain('deps:')
+    expect(code).toContain('neverBundle:')
+    expect(code).not.toContain('external:')
+  })
+
+  test('noExternal should move to deps.alwaysBundle', () => {
+    const input = `
+      export default {
+        noExternal: ['foo'],
+      }
+    `
+    const { code } = transform(input, 'tsup.config.ts')
+    expect(code).toContain('deps:')
+    expect(code).toContain('alwaysBundle:')
+    expect(code).not.toContain('noExternal:')
+  })
+
+  test('multiple deps options should merge into single deps object', () => {
+    const input = `
+      export default {
+        external: ['foo'],
+        noExternal: ['bar'],
+      }
+    `
+    const { code } = transform(input, 'tsup.config.ts')
+    expect(code).toContain('deps:')
+    expect(code).toContain('neverBundle:')
+    expect(code).toContain('alwaysBundle:')
+    expect(code).not.toContain('external:')
+    expect(code).not.toContain('noExternal:')
+  })
+})
+
 describe('warning options', () => {
   test('metafile should emit warning (use Vite DevTools)', () => {
     const input = `
diff --git a/packages/migrate/src/helpers/tsup-config.ts b/packages/migrate/src/helpers/tsup-config.ts
@@ -36,6 +36,12 @@ const PROPERTY_RENAMES: Record<string, string> = {
   cjsInterop: 'cjsDefault',
 }
 
+// Properties to move under `deps` namespace: oldName -> newNameUnderDeps
+const DEPS_NAMESPACE_RENAMES: Record<string, string> = {
+  external: 'neverBundle',
+  noExternal: 'alwaysBundle',
+}
+
 /**
  * Transform tsup config code to tsdown config code.
  * This function applies all migration rules and returns the transformed code
@@ -194,7 +200,20 @@ export function transformTsupConfig(
     edits.push(node.replace("nodeProtocol: 'strip'"))
   }
 
-  // 7. Transform tsup/TSUP identifiers
+  // 7. Move properties into deps namespace
+  const depsProperties: { name: string; value: string }[] = []
+  for (const [oldName, newName] of Object.entries(DEPS_NAMESPACE_RENAMES)) {
+    const pair = findPropertyPair(oldName)
+    if (pair) {
+      const valueNode = pair.field('value')
+      if (valueNode) {
+        depsProperties.push({ name: newName, value: valueNode.text() })
+      }
+      edits.push(pair.replace(''))
+    }
+  }
+
+  // 8. Transform tsup/TSUP identifiers
   const tsupIdentifiers = root.findAll({
     rule: {
       kind: 'identifier',
@@ -287,6 +306,13 @@ export function transformTsupConfig(
 
   const missingDefaults: string[] = []
   if (configObjectNode) {
+    if (depsProperties.length > 0) {
+      const depsEntries = depsProperties
+        .map((p) => `${p.name}: ${p.value}`)
+        .join(',\n    ')
+      missingDefaults.push(`deps: {\n    ${depsEntries},\n  }`)
+    }
+
     if (!hasOption('format')) missingDefaults.push("format: 'cjs'")
     if (!hasOption('clean')) missingDefaults.push('clean: false')
     if (!hasOption('dts')) missingDefaults.push('dts: false')
