fix(node-protocol): respect alias and tsconfig paths when stripping node: prefix (#773)

lazuee · sxzz · web-flow · commit b1dd232aef5d · 2026-02-26T14:19:57.000+09:00
* fix(node-protocol): respect alias and tsconfig paths when stripping node: prefix

* refactor

* fix(tests): update assertions to use regex for path and crypto imports

* refactor: reorder test cases

---------

Co-authored-by: Kevin Deng &lt;sxzz@sxzz.moe&gt;
diff --git a/src/features/node-protocol.ts b/src/features/node-protocol.ts
@@ -22,10 +22,18 @@ export function NodeProtocolPlugin(nodeProtocolOption: 'strip' | true): Plugin {
       },
       handler:
         nodeProtocolOption === 'strip'
-          ? (id) => {
+          ? async function (id, ...args) {
+              // strip the `node:` prefix
+              const strippedId = id.slice(5 /* "node:".length */)
+
+              // check if another resolver (e.g., tsconfig paths, alias) handles the stripped id
+              const resolved = await this.resolve(strippedId, ...args)
+              if (resolved && !resolved.external) {
+                return resolved
+              }
+
               return {
-                // strip the `node:` prefix
-                id: id.slice(5),
+                id: strippedId,
                 external: true,
                 moduleSideEffects: false,
               }
diff --git a/tests/__snapshots__/issues/772.snap.md b/tests/__snapshots__/issues/772.snap.md
@@ -0,0 +1,22 @@
+## index.mjs
+
+```mjs
+//#region crypto-polyfill.ts
+function randomUUID() {
+	return "polyfill-uuid";
+}
+
+//#endregion
+//#region path-polyfill.ts
+function resolve(...args) {
+	return args.join("/");
+}
+
+//#endregion
+//#region index.ts
+const id = randomUUID();
+const dir = resolve(".");
+
+//#endregion
+export { dir, id };
+```
diff --git a/tests/issues.test.ts b/tests/issues.test.ts
@@ -193,4 +193,30 @@ describe('issues', () => {
     expect(fileMap['entry1.css']).toContain('class-shared')
     expect(fileMap['entry2.css']).toContain('class-shared')
   })
+
+  test('#772', async (context) => {
+    const { fileMap, outputFiles } = await testBuild({
+      context,
+      files: {
+        'index.ts': `import { randomUUID } from 'node:crypto'\nimport { resolve } from 'node:path'\nexport const id = randomUUID()\nexport const dir = resolve('.')`,
+        'crypto-polyfill.ts': `export function randomUUID() { return 'polyfill-uuid' }`,
+        'path-polyfill.ts': `export function resolve(...args: string[]) { return args.join('/') }`,
+        'tsconfig.json': JSON.stringify({
+          compilerOptions: {
+            paths: { crypto: ['./crypto-polyfill'] },
+          },
+        }),
+      },
+      options: {
+        nodeProtocol: 'strip',
+        alias: { path: './path-polyfill' },
+        tsconfig: 'tsconfig.json',
+      },
+    })
+    expect(outputFiles).toContain('index.mjs')
+    expect(fileMap['index.mjs']).toContain('args.join')
+    expect(fileMap['index.mjs']).not.toMatch(/from ['"]path['"]/)
+    expect(fileMap['index.mjs']).toContain('polyfill-uuid')
+    expect(fileMap['index.mjs']).not.toMatch(/from ['"]crypto['"]/)
+  })
 })
