feat(generateStage): The entry module shared by facade entry and entr…#9692
Open
AliceLanniste wants to merge 2 commits into
Open
feat(generateStage): The entry module shared by facade entry and entr…#9692AliceLanniste wants to merge 2 commits into
AliceLanniste wants to merge 2 commits into
Conversation
AliceLanniste
marked this pull request as ready for review
June 9, 2026 12:00
AliceLanniste
force-pushed
the
facade__shared__entry_module_with_entry_chunk
branch
from
June 19, 2026 12:31
e83f188 to
0bf39c6
Compare
AliceLanniste
requested review from
IWANABETHATGUY,
hyfdev and
shulaoda
as code owners
June 19, 2026 12:31
Merging this PR will not alter performance
Comparing Footnotes
|
…y is re-export external, unnecessary imports can be deleted.
AliceLanniste
force-pushed
the
facade__shared__entry_module_with_entry_chunk
branch
from
June 19, 2026 13:39
0bf39c6 to
33b230e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #7281
Summary
Multi UserDefined entry chunks point to the same entry module; Rolldown treats one of them as the facade entry. #7281,
entry2.jsis treated as the facade entry, and theimport ./xxxstatement—which is required for a facade entry—has been added.However,no import statement is required.
I have therefore added the following checks:
sourceclauses in a re-export statement must be an external module;