Skip to content

feat(generateStage): The entry module shared by facade entry and entr…#9692

Open
AliceLanniste wants to merge 2 commits into
rolldown:mainfrom
AliceLanniste:facade__shared__entry_module_with_entry_chunk
Open

feat(generateStage): The entry module shared by facade entry and entr…#9692
AliceLanniste wants to merge 2 commits into
rolldown:mainfrom
AliceLanniste:facade__shared__entry_module_with_entry_chunk

Conversation

@AliceLanniste

@AliceLanniste AliceLanniste commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

close #7281

Summary

Multi UserDefined entry chunks point to the same entry module; Rolldown treats one of them as the facade entry. #7281, entry2.js is treated as the facade entry, and the import ./xxx statement—which is required for a facade entry—has been added.

// entry.js
export * from "node:fs"

// entry2.js
import "./entry.js";

export * from "node:fs"

However,no import statement is required.

I have therefore added the following checks:

  1. Collect the facade entry and entry corresponding to the same entry module
  2. All content within the entry module must be in the form of re-exports.
  3. At least one of the source clauses in a re-export statement must be an external module;
  4. Indirect re-exports check whether the final module is an external module.

@AliceLanniste
AliceLanniste marked this pull request as ready for review June 9, 2026 12:00
@AliceLanniste AliceLanniste changed the title feat:The entry module shared by facade entry and entr… feat(generateStage):The entry module shared by facade entry and entr… Jun 9, 2026
@AliceLanniste AliceLanniste changed the title feat(generateStage):The entry module shared by facade entry and entr… feat(generateStage): The entry module shared by facade entry and entr… Jun 9, 2026
@AliceLanniste
AliceLanniste force-pushed the facade__shared__entry_module_with_entry_chunk branch from e83f188 to 0bf39c6 Compare June 19, 2026 12:31
@codspeed-hq

codspeed-hq Bot commented Jun 19, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 7 untouched benchmarks
⏩ 10 skipped benchmarks1


Comparing AliceLanniste:facade__shared__entry_module_with_entry_chunk (c6051cb) with main (752820d)

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

…y is re-export external, unnecessary imports can be deleted.
@AliceLanniste
AliceLanniste force-pushed the facade__shared__entry_module_with_entry_chunk branch from 0bf39c6 to 33b230e Compare June 19, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: improve output of export_star_from_external_as_shared_entries

1 participant