chore(deps): upgrade oxc to 0.133.0 by Dunqing · Pull Request #9563 · rolldown/rolldown

Dunqing · 2026-05-26T06:54:46Z

Summary

Bump oxc Rust crates and @oxc-project/* / oxc-* npm packages from 0.132.0 to 0.133.0. ~~Bump oxc_resolver / oxc_resolver_napi from 11.19.1 to 11.19.2.~~
Regenerate embedded_helpers.rs to point at @[email protected] (version string only — no helper-content drift).
Handle two new oxc fields surfaced by cargo check:
- oxc::transformer::DecoratorOptions.strict_null_checks — hardcoded to true in the From impl (matches oxc's default). Exposing it through rolldown's wrapper would be a separate API change.
- oxc_minify_napi::CodegenOptions.legal_comments — set to None.
Extend DecoratorOptionSchema and CodegenOptionsSchema in validator.ts to mirror the new optional fields.
Refresh 32 snapshots driven by upstream oxc PR #22547 ("fix(minifier): preserve IIFE structure in DCE-only mode"). In DCE-only mode (rolldown's per-module preprocess via Compressor::dead_code_elimination_with_scoping), oxc no longer inlines (() => …)() IIFEs that carry — or could carry — /*#__PURE__*/ annotations, so downstream tree-shaking can see them. Empty-IIFE elision still fires. Side effects: property_read_side_effects now correctly tree-shakes /*#__PURE__*/ test().a.b.c; lines and drops the previously spurious INVALID_ANNOTATION warnings; TS class (() => new Foo())() patterns and Symbol((() => Math.random() < 0.5)() ? …) calls are preserved as the sources actually wrote them; dce_of_iife/diff.md divergence vs esbuild shrunk.

Issues fixed

Pulled in from upstream oxc fixes between 0.132.0 and 0.133.0:

Fixes [Bug]: Pure-annotated IIFE returning an array is inlined #9437 — Pure-annotated IIFE returning an array is inlined (via oxc #22547)
Fixes [Bug]: Cross-module enum inlining mis-folds auto-increment member to 0 #9494 — Cross-module enum inlining mis-folds auto-increment member to 0 (via oxc #22646)
Fixes [Bug]: Rolldown drops @preserve from /* #__PURE__ -- @preserve */ comments, unlike Rollup #9408 — Rolldown drops @preserve from /* #__PURE__ -- @preserve */ comments (via oxc #22525 "preserve verbatim text of pure/no-side-effects comments")
Partially addresses Tracking: all skipped esbuild and rollup tests #8688 — dce/dce_of_iife esbuild divergence shrunk (via oxc #22589 "drop empty-body IIFE wrapper when called with arguments")

Also relevant: oxc #22566 reduces false-positive PureNotApplied warnings (the warnings system landed in rolldown #9381) by applying PURE through member-access chains.

Test plan

cargo check --workspace --all-targets
just update-generated-code
just test-update
just ued
just roll — 32 Rust suites pass (0 failed), 1212 node tests pass (0 failed), TS lint+types clean on 804 files

## Summary - Bump oxc Rust crates and `@oxc-project/*` / `oxc-*` npm packages from `0.132.0` to `0.133.0`. Bump `oxc_resolver` / `oxc_resolver_napi` from `11.19.1` to `11.19.2`. - Regenerate `embedded_helpers.rs` to point at `@[email protected]` (version string only — no helper-content drift). - Handle two new oxc fields surfaced by `cargo check`: - `oxc::transformer::DecoratorOptions.strict_null_checks` — hardcoded to `true` in the `From` impl (matches oxc's default). Exposing it through rolldown's wrapper would be a separate API change. - `oxc_minify_napi::CodegenOptions.legal_comments` — set to `None`. - Extend `DecoratorOptionSchema` and `CodegenOptionsSchema` in `validator.ts` to mirror the new optional fields. - Refresh 32 snapshots driven by upstream oxc PR [#22547](oxc-project/oxc#22547) ("fix(minifier): preserve IIFE structure in DCE-only mode"). In DCE-only mode (rolldown's per-module preprocess via \`Compressor::dead_code_elimination_with_scoping\`), oxc no longer inlines \`(() => …)()\` IIFEs that carry — or could carry — \`/*#__PURE__*/\` annotations, so downstream tree-shaking can see them. Empty-IIFE elision still fires. Side effects: \`property_read_side_effects\` now correctly tree-shakes \`/*#__PURE__*/ test().a.b.c;\` lines and drops the previously spurious \`INVALID_ANNOTATION\` warnings; TS class \`(() => new Foo())()\` patterns and \`Symbol((() => Math.random() < 0.5)() ? …)\` calls are preserved as the sources actually wrote them; \`dce_of_iife/diff.md\` divergence vs esbuild shrunk. ## Test plan - [x] \`cargo check --workspace --all-targets\` - [x] \`just update-generated-code\` - [x] \`just test-update\` - [x] \`just ued\` - [x] \`just roll\` — 32 Rust suites pass (0 failed), 1212 node tests pass (0 failed), TS lint+types clean on 804 files

Dunqing · 2026-05-26T06:55:02Z

chore(deps): upgrade oxc to 0.133.0 #9563 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2026-05-26T06:56:00Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`6c4a785`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/6a167323ed1584000854d696
😎 Deploy Preview	https://deploy-preview-9563--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

socket-security · 2026-05-26T06:56:13Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	Maintenance
npm/@oxc-project/types@0.132.0 ⏵ 0.133.0		^-1
npm/@oxc-project/runtime@0.133.0
cargo/oxc_minify_napi@0.132.0 ⏵ 0.133.0
cargo/oxc_napi@0.132.0 ⏵ 0.133.0
cargo/oxc_parser_napi@0.132.0 ⏵ 0.133.0
cargo/oxc_transform_napi@0.132.0 ⏵ 0.133.0
npm/oxc-minify@0.133.0
cargo/oxc@0.132.0 ⏵ 0.133.0
cargo/oxc_allocator@0.132.0 ⏵ 0.133.0
cargo/oxc_ecmascript@0.132.0 ⏵ 0.133.0
cargo/oxc_str@0.132.0 ⏵ 0.133.0
cargo/oxc_traverse@0.132.0 ⏵ 0.133.0
npm/oxc-transform@0.133.0
npm/oxc-parser@0.132.0 ⏵ 0.133.0	⁺⁹	^-1

View full report

socket-security · 2026-05-26T06:56:15Z

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

codspeed-hq · 2026-05-26T07:02:23Z

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 10 skipped benchmarks¹

_{Comparing chore/upgrade-oxc-0.133.0 (6c4a785) with main (b3ebfe0)²}

10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (15a8451) during the generation of this report, so b3ebfe0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

## Summary Builds on #9563, which upgraded oxc to `0.133.0` and surfaced the `strictNullChecks` decorator-metadata option (from oxc-project/oxc#22266) in the TypeScript types, the validator, and the generated binding. However, #9563's Rust `From<DecoratorOptions> for oxc::transformer::DecoratorOptions` hardcodes `strict_null_checks: true`, and the napi options normalizer doesn't carry the field, so `transform.decorator.strictNullChecks: false` is currently **silently ignored** through rolldown's transform/bundle pipeline (the option exists in the type surface but does nothing). This PR wires it through so the option actually takes effect. ## What changed - `rolldown_common::DecoratorOptions` gains a `strict_null_checks: Option<bool>` field; its `From` impl now uses `options.strict_null_checks.unwrap_or(true)` (mirroring oxc's own default) instead of the hardcoded `true`. - `normalize_binding_transform_options` forwards `strict_null_checks` from the incoming napi options into `DecoratorOptions` (previously dropped). - Docs (`transform.md`) + tests. ## Behavior When `emitDecoratorMetadata` is enabled (legacy decorators): | Source | `strictNullChecks: true` (default) | `strictNullChecks: false` | | --- | --- | --- | | `string \| null` | `Object` (matches `tsc` strict) | `String` (matches `tsc --strictNullChecks false` / `babel-plugin-transform-typescript-metadata`) | | `number \| undefined` | `Object` | `Number` | Defaults to `true`, so there is **no behavior change for existing users**; only an explicit `strictNullChecks: false` is newly honored. > Note: this is **not** inferred from `tsconfig.json` *yet*. `oxc_resolver`'s `CompilerOptions` does not currently parse `strictNullChecks`, so (unlike `experimentalDecorators`/`emitDecoratorMetadata`) it must be set explicitly on `transform.decorator`. Documented in `transform.md`. See Follow-up below. ## Follow-up: inferring from `tsconfig.json` [oxc-project/oxc-resolver#1166](oxc-project/oxc-resolver#1166) (`feat(tsconfig): parse strict and strictNullChecks compiler options`) is the enabling resolver-side change. It adds `strict`/`strictNullChecks` to `CompilerOptions`, inherits them through `extends`, and exposes `effective_strict_null_checks()` implementing tsc's `strictNullChecks ?? strict` precedence. Once it lands and is released, a small downstream follow-up here can forward `compiler_options.effective_strict_null_checks()` in `merge_transform_options_with_tsconfig` into `DecoratorOptions.strict_null_checks` (mapping `None` to the transformer default), plus add the field to the inline `BindingTsconfigCompilerOptions` path, making `strictNullChecks` auto-inferred from tsconfig like the other decorator options. This PR is intentionally scoped to the explicit option so it's useful immediately and independent of that release. ## Test plan - [x] Rebased/merged on top of the latest `main` (which already has oxc `0.133.0`); `cargo check --workspace` passes - [x] New `transform.test.ts` cases assert `string | null` emits `Object` by default and `String` under `strictNullChecks: false` (verified locally; the full suite runs in CI) ## AI usage disclosure Per the [AI Usage Policy](https://rolldown.rs/contribution-guide#ai-usage-policy): AI assistance (Claude Code) was used to implement and verify this change. I have reviewed and tested it locally. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]> Co-authored-by: shulaoda <[email protected]>

@kylecannon

## [1.0.3] - 2026-05-27 ### 🚀 Features - transform: respect decorator strictNullChecks option (#9580) by @kylecannon - drop `defer` keyword (#9503) by @TheAlexLichter ### 🐛 Bug Fixes - ci: create target dir before cargo release-oxc update (#9584) by @shulaoda - ci: reorder prepare-release steps to avoid dirty git check failure (#9583) by @shulaoda - testing: canonicalize temp dir early and use platform-specific separator in test262 (#9582) by @shulaoda - testing: resolve symlinked temp dir in test262 snapshot normalization (#9581) by @shulaoda - testing: canonicalize temp dir path in test262 snapshot normalization (#9579) by @shulaoda - dev: `onOutput` called twice when initial build fails (#9552) by @hyf0 - dev: make `ensureCurrentBuildFinish` not returning error when engine closes (#9564) by @h-a-n-a - oxc-runtime: route require() to CJS helper variant (#9263) (#9526) by @IWANABETHATGUY - generator: use exporter chunk's export mode for CJS default re-exports (#9299) (#9529) by @IWANABETHATGUY - rolldown: always run reduced-atom static cycle check (#9441) (#9514) by @IWANABETHATGUY - apply transform.dropLabels before scanning (#9521) (#9522) by @IWANABETHATGUY - rolldown_watcher: take `rolldown` dep through the workspace (#9510) by @Boshen - cache: keep the scan-stage cache consistent when a build fails (#9495) by @h-a-n-a - skip JSON default-import namespace optimization for write targets (#9484) (#9489) by @IWANABETHATGUY - deps: skip pnpm frozen-lockfile on Netlify to dodge catalog mismatch bug (#9471) by @Boshen ### 🚜 Refactor - oxc-runtime: use Cow for helper path construction (#9538) by @IWANABETHATGUY - fold import defer phase drop into PreProcessor (#9524) by @IWANABETHATGUY - distinguish `map: null` vs `map: undefined` in transform hook output (#9497) by @sapphi-red ### 📚 Documentation - explain the policy for Rust crates (#9547) by @sapphi-red - cache: add design doc for cache (#9544) by @h-a-n-a - guide/troubleshooting: add TDZ error section (#9537) by @sapphi-red - dev-engine: add design doc for dev-engine (#9479) by @h-a-n-a - lazy-barrel: tweak some words (#9483) by @shulaoda - lazy-barrel: expand reasoning behind LARGE_BARREL_MODULES advice (#9477) by @shulaoda ### ⚡ Performance - generate: thread ast_table by value into codegen consumer (#9555) by @Boshen - finalizers: replace `_reExport` construction with a direct call to avoid calling `clone_in` (#9501) by @Dunqing - reorder hot-path boolean checks to short-circuit on cheap predicates first (#9523) by @Boshen ### 🧪 Testing - rolldown: regression fixture for #9401 (#9418) by @IWANABETHATGUY - failing test for #9441 (#9504) by @TheAlexLichter ### ⚙️ Miscellaneous Tasks - deps: upgrade oxc to 0.133.0 (#9563) by @Dunqing - deps: update crate-ci/typos action to v1.46.3 (#9576) by @renovate[bot] - deps: update mimalloc-safe to 0.1.62 (#9577) by @shulaoda - mimalloc-safe: update to a bug-fix branch for verification (#9569) by @shulaoda - deps: update test262 submodule for tests (#9551) by @rolldown-guard[bot] - point published crates' readme to root README.md (#9553) by @Boshen - replace actions-cool/issues-helper with gh CLI (#9543) by @Boshen - deps: update cargo-shear to 1.12.4 (#9541) by @Boshen - deps: update taiki-e/install-action action to v2.79.4 (#9535) by @renovate[bot] - deps: update github actions (#9532) by @renovate[bot] - deps: update rust crates (#9534) by @renovate[bot] - deps: update npm packages (#9533) by @renovate[bot] - gate experimental/testing-only items to silence dead_code in publish builds (#9517) by @Boshen - docs: deploy to Void (#9509) by @Boshen - release: set up cargo-release-oxc for publishing crates (#9476) by @Boshen - rolldown_plugin_lazy_compilation: add missing description (#9507) by @Boshen - mimalloc-safe: update to a bug-fix branch for verification (#9506) by @shulaoda - deps: update crate-ci/typos action to v1.46.2 (#9468) by @renovate[bot] ### ❤️ New Contributors * @kylecannon made their first contribution in [#9580](#9580)

@kylecannon

## [1.0.3] - 2026-05-27 ### 🚀 Features - transform: respect decorator strictNullChecks option (#9580) by @kylecannon - drop `defer` keyword (#9503) by @TheAlexLichter ### 🐛 Bug Fixes - ci: create target dir before cargo release-oxc update (#9584) by @shulaoda - ci: reorder prepare-release steps to avoid dirty git check failure (#9583) by @shulaoda - testing: canonicalize temp dir early and use platform-specific separator in test262 (#9582) by @shulaoda - testing: resolve symlinked temp dir in test262 snapshot normalization (#9581) by @shulaoda - testing: canonicalize temp dir path in test262 snapshot normalization (#9579) by @shulaoda - dev: `onOutput` called twice when initial build fails (#9552) by @hyf0 - dev: make `ensureCurrentBuildFinish` not returning error when engine closes (#9564) by @h-a-n-a - oxc-runtime: route require() to CJS helper variant (#9263) (#9526) by @IWANABETHATGUY - generator: use exporter chunk's export mode for CJS default re-exports (#9299) (#9529) by @IWANABETHATGUY - rolldown: always run reduced-atom static cycle check (#9441) (#9514) by @IWANABETHATGUY - apply transform.dropLabels before scanning (#9521) (#9522) by @IWANABETHATGUY - rolldown_watcher: take `rolldown` dep through the workspace (#9510) by @Boshen - cache: keep the scan-stage cache consistent when a build fails (#9495) by @h-a-n-a - skip JSON default-import namespace optimization for write targets (#9484) (#9489) by @IWANABETHATGUY - deps: skip pnpm frozen-lockfile on Netlify to dodge catalog mismatch bug (#9471) by @Boshen ### 🚜 Refactor - oxc-runtime: use Cow for helper path construction (#9538) by @IWANABETHATGUY - fold import defer phase drop into PreProcessor (#9524) by @IWANABETHATGUY - distinguish `map: null` vs `map: undefined` in transform hook output (#9497) by @sapphi-red ### 📚 Documentation - explain the policy for Rust crates (#9547) by @sapphi-red - cache: add design doc for cache (#9544) by @h-a-n-a - guide/troubleshooting: add TDZ error section (#9537) by @sapphi-red - dev-engine: add design doc for dev-engine (#9479) by @h-a-n-a - lazy-barrel: tweak some words (#9483) by @shulaoda - lazy-barrel: expand reasoning behind LARGE_BARREL_MODULES advice (#9477) by @shulaoda ### ⚡ Performance - generate: thread ast_table by value into codegen consumer (#9555) by @Boshen - finalizers: replace `_reExport` construction with a direct call to avoid calling `clone_in` (#9501) by @Dunqing - reorder hot-path boolean checks to short-circuit on cheap predicates first (#9523) by @Boshen ### 🧪 Testing - rolldown: regression fixture for #9401 (#9418) by @IWANABETHATGUY - failing test for #9441 (#9504) by @TheAlexLichter ### ⚙️ Miscellaneous Tasks - deps: upgrade oxc to 0.133.0 (#9563) by @Dunqing - deps: update crate-ci/typos action to v1.46.3 (#9576) by @renovate[bot] - deps: update mimalloc-safe to 0.1.62 (#9577) by @shulaoda - mimalloc-safe: update to a bug-fix branch for verification (#9569) by @shulaoda - deps: update test262 submodule for tests (#9551) by @rolldown-guard[bot] - point published crates' readme to root README.md (#9553) by @Boshen - replace actions-cool/issues-helper with gh CLI (#9543) by @Boshen - deps: update cargo-shear to 1.12.4 (#9541) by @Boshen - deps: update taiki-e/install-action action to v2.79.4 (#9535) by @renovate[bot] - deps: update github actions (#9532) by @renovate[bot] - deps: update rust crates (#9534) by @renovate[bot] - deps: update npm packages (#9533) by @renovate[bot] - gate experimental/testing-only items to silence dead_code in publish builds (#9517) by @Boshen - docs: deploy to Void (#9509) by @Boshen - release: set up cargo-release-oxc for publishing crates (#9476) by @Boshen - rolldown_plugin_lazy_compilation: add missing description (#9507) by @Boshen - mimalloc-safe: update to a bug-fix branch for verification (#9506) by @shulaoda - deps: update crate-ci/typos action to v1.46.2 (#9468) by @renovate[bot] ### ❤️ New Contributors * @kylecannon made their first contribution in [#9580](#9580)

Dunqing marked this pull request as ready for review May 26, 2026 06:55

Dunqing requested review from IWANABETHATGUY and shulaoda May 26, 2026 07:03

IWANABETHATGUY approved these changes May 27, 2026

View reviewed changes

shulaoda self-assigned this May 27, 2026

shulaoda added 2 commits May 27, 2026 12:25

Merge branch 'main' into chore/upgrade-oxc-0.133.0

9d26807

u

6c4a785

shulaoda approved these changes May 27, 2026

View reviewed changes

Comment thread Cargo.toml Outdated

Comment thread Cargo.toml Outdated

shulaoda merged commit 8326121 into main May 27, 2026
34 checks passed

shulaoda deleted the chore/upgrade-oxc-0.133.0 branch May 27, 2026 04:52

kylecannon mentioned this pull request May 27, 2026

feat(transform): respect decorator strictNullChecks option #9580

Merged

2 tasks

rolldown-guard Bot mentioned this pull request May 27, 2026

release: v1.0.3 for rust crates #9585

Merged

shulaoda mentioned this pull request May 27, 2026

release: v1.0.3 #9586

Merged

TheAlexLichter mentioned this pull request Jun 4, 2026

PURE annotation bug #9496

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): upgrade oxc to 0.133.0#9563

chore(deps): upgrade oxc to 0.133.0#9563
shulaoda merged 3 commits into
mainfrom
chore/upgrade-oxc-0.133.0

Dunqing commented May 26, 2026 •

edited by shulaoda

Loading

Uh oh!

Dunqing commented May 26, 2026 •

edited

Loading

Uh oh!

netlify Bot commented May 26, 2026 •

edited

Loading

Uh oh!

socket-security Bot commented May 26, 2026 •

edited

Loading

Uh oh!

socket-security Bot commented May 26, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented May 26, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Dunqing commented May 26, 2026 • edited by shulaoda Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Issues fixed

Test plan

Uh oh!

Dunqing commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

netlify Bot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

socket-security Bot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security Bot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq Bot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Dunqing commented May 26, 2026 •

edited by shulaoda

Loading

Dunqing commented May 26, 2026 •

edited

Loading

netlify Bot commented May 26, 2026 •

edited

Loading

socket-security Bot commented May 26, 2026 •

edited

Loading

socket-security Bot commented May 26, 2026 •

edited

Loading

codspeed-hq Bot commented May 26, 2026 •

edited

Loading