Skip to content

fix: align dynamic already-loaded reduction with Rollup#9518

Draft
IWANABETHATGUY wants to merge 1 commit into
mainfrom
05-22-align-dynamic-already-loaded-rollup
Draft

fix: align dynamic already-loaded reduction with Rollup#9518
IWANABETHATGUY wants to merge 1 commit into
mainfrom
05-22-align-dynamic-already-loaded-rollup

Conversation

@IWANABETHATGUY

@IWANABETHATGUY IWANABETHATGUY commented May 22, 2026

Copy link
Copy Markdown
Member

Stacked on #9514.

Summary

  • run avoidRedundantChunkLoads after manual chunk materialization
  • skip already-assigned/manual modules when building dynamic already-loaded atoms
  • apply candidate reductions as a batch, validating the resulting mixed chunk graph

Tests

  • just dt crates\rolldown\tests\rolldown\issues\8361_2_config.json
  • just dt crates\rolldown\tests\rolldown\issues\8595_config.json
  • just dt crates\rolldown\tests\rolldown\issues\9225_config.json
  • just dt crates\rolldown\tests\rolldown\function\chunk_optimization\cjs_wrapper_must_not_be_hoisted_to_entry_cycle_config.json
  • just fix-rust
  • just test-rust

@IWANABETHATGUY Graphite App

IWANABETHATGUY commented May 22, 2026

Copy link
Copy Markdown
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY mentioned this pull request May 22, 2026
Merged
@codspeed-hq

codspeed-hq Bot commented May 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 10 skipped benchmarks1

Comparing 05-22-align-dynamic-already-loaded-rollup (75dad75) with main (2c533e4)2

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on 05-22-fix_9441-cd (65712e1) during the generation of this report, so main (2c533e4) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@IWANABETHATGUY IWANABETHATGUY force-pushed the 05-22-align-dynamic-already-loaded-rollup branch from 596353f to 75dad75 Compare May 22, 2026 15:14
@IWANABETHATGUY IWANABETHATGUY marked this pull request as draft May 22, 2026 16:48
@graphite-app graphite-app Bot changed the base branch from 05-22-fix_9441-cd to graphite-base/9518 May 24, 2026 02:53
@graphite-app graphite-app Bot force-pushed the 05-22-align-dynamic-already-loaded-rollup branch from 75dad75 to d622098 Compare May 24, 2026 02:58
@graphite-app graphite-app Bot force-pushed the graphite-base/9518 branch from 65712e1 to 7ae80f0 Compare May 24, 2026 02:58
@graphite-app graphite-app Bot changed the base branch from graphite-base/9518 to main May 24, 2026 02:59
@graphite-app graphite-app Bot force-pushed the 05-22-align-dynamic-already-loaded-rollup branch from d622098 to 5712daf Compare May 24, 2026 02:59
@netlify

netlify Bot commented May 24, 2026

Copy link
Copy Markdown

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 5712daf
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6a12697fc78c36000845a902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@IWANABETHATGUY IWANABETHATGUY

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@IWANABETHATGUY