fix(rolldown): always run reduced-atom static cycle check (#9441) by IWANABETHATGUY · Pull Request #9514 · rolldown/rolldown

IWANABETHATGUY · 2026-05-22T10:02:25Z

Removes the should_check_reduced_atom_static_cycle guard that restricted the reduced-atom static cycle detection to manualCodeSplitting or strict preserveEntrySignatures. The cycle check now applies universally during dynamic-import already-loaded optimization, fixing the CJS wrapper hoisting runtime cycle reported in #9441.

Snapshots for issues 8361_2 and 8595 are updated accordingly, and the failing fixture added in the parent commit is renamed to its non-. form.

Closes #9441

IWANABETHATGUY · 2026-05-22T10:02:39Z

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2026-05-22T10:02:43Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`7ae80f0`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/6a12682858007600087d15e1

pkg-pr-new · 2026-05-22T10:27:23Z

Open in StackBlitz

@rolldown/browser

npm i https://pkg.pr.new/rolldown/rolldown/@rolldown/browser@9514

@rolldown/debug

npm i https://pkg.pr.new/rolldown/rolldown/@rolldown/debug@9514

rolldown

npm i https://pkg.pr.new/rolldown/rolldown@9514

@rolldown/binding-android-arm64

npm i https://pkg.pr.new/rolldown/rolldown/@rolldown/binding-android-arm64@9514

@rolldown/binding-darwin-arm64

npm i https://pkg.pr.new/rolldown/rolldown/@rolldown/binding-darwin-arm64@9514

@rolldown/binding-darwin-x64

npm i https://pkg.pr.new/rolldown/rolldown/@rolldown/binding-darwin-x64@9514

@rolldown/binding-freebsd-x64

npm i https://pkg.pr.new/rolldown/rolldown/@rolldown/binding-freebsd-x64@9514

@rolldown/binding-linux-arm-gnueabihf

npm i https://pkg.pr.new/rolldown/rolldown/@rolldown/binding-linux-arm-gnueabihf@9514

@rolldown/binding-linux-arm64-gnu

npm i https://pkg.pr.new/rolldown/rolldown/@rolldown/binding-linux-arm64-gnu@9514

@rolldown/binding-linux-arm64-musl

npm i https://pkg.pr.new/rolldown/rolldown/@rolldown/binding-linux-arm64-musl@9514

@rolldown/binding-linux-ppc64-gnu

npm i https://pkg.pr.new/rolldown/rolldown/@rolldown/binding-linux-ppc64-gnu@9514

@rolldown/binding-linux-s390x-gnu

npm i https://pkg.pr.new/rolldown/rolldown/@rolldown/binding-linux-s390x-gnu@9514

@rolldown/binding-linux-x64-gnu

npm i https://pkg.pr.new/rolldown/rolldown/@rolldown/binding-linux-x64-gnu@9514

@rolldown/binding-linux-x64-musl

npm i https://pkg.pr.new/rolldown/rolldown/@rolldown/binding-linux-x64-musl@9514

@rolldown/binding-openharmony-arm64

npm i https://pkg.pr.new/rolldown/rolldown/@rolldown/binding-openharmony-arm64@9514

@rolldown/binding-wasm32-wasi

npm i https://pkg.pr.new/rolldown/rolldown/@rolldown/binding-wasm32-wasi@9514

@rolldown/binding-win32-arm64-msvc

npm i https://pkg.pr.new/rolldown/rolldown/@rolldown/binding-win32-arm64-msvc@9514

@rolldown/binding-win32-x64-msvc

npm i https://pkg.pr.new/rolldown/rolldown/@rolldown/binding-win32-x64-msvc@9514

commit: 65712e1

codspeed-hq · 2026-05-22T15:23:07Z

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 10 skipped benchmarks¹

_{Comparing 05-22-fix_9441-cd (65712e1) with main (2c533e4)²}

10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (a9e23ec) during the generation of this report, so 2c533e4 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

IWANABETHATGUY · 2026-05-24T02:52:52Z

Merge activity

May 24, 2:52 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
May 24, 2:52 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
May 24, 2:58 AM UTC: Merged by the Graphite merge queue.

) Removes the `should_check_reduced_atom_static_cycle` guard that restricted the reduced-atom static cycle detection to `manualCodeSplitting` or strict `preserveEntrySignatures`. The cycle check now applies universally during dynamic-import already-loaded optimization, fixing the CJS wrapper hoisting runtime cycle reported in #9441. Snapshots for issues 8361_2 and 8595 are updated accordingly, and the failing fixture added in the parent commit is renamed to its non-`.` form. Closes #9441

The bug is fixed by #9514, so this PR only adds the regression test. close #9401 The fixture exercises the dynamic-import + CJS-require shape from the issue: a static `assertNoStaticImportCycle` check against the dist graph plus a runtime `await import('./dist/entry-0.js')` smoke to catch the original `TypeError: __exportAll is not a function`. **Why a regression test still matters.** Any optimization that moves or merges the runtime host has to anticipate the static imports that follow. There is no type or invariant enforcing this — it lives entirely in the head of whoever wrote each optimization pass. Forgetting it silently introduces a circular import, which is exactly the bug in #9401. **Planned follow-up.** A subsequent PR will restructure this: split the runtime module into a standalone chunk during optimization, then merge it into an existing chunk as a final step *after* helper usages are attached. Optimization will then see a complete graph, and the kind of ad-hoc guarding #9514 added can be removed.

) (rolldown#9514) Removes the `should_check_reduced_atom_static_cycle` guard that restricted the reduced-atom static cycle detection to `manualCodeSplitting` or strict `preserveEntrySignatures`. The cycle check now applies universally during dynamic-import already-loaded optimization, fixing the CJS wrapper hoisting runtime cycle reported in rolldown#9441. Snapshots for issues 8361_2 and 8595 are updated accordingly, and the failing fixture added in the parent commit is renamed to its non-`.` form. Closes rolldown#9441

The bug is fixed by rolldown#9514, so this PR only adds the regression test. close rolldown#9401 The fixture exercises the dynamic-import + CJS-require shape from the issue: a static `assertNoStaticImportCycle` check against the dist graph plus a runtime `await import('./dist/entry-0.js')` smoke to catch the original `TypeError: __exportAll is not a function`. **Why a regression test still matters.** Any optimization that moves or merges the runtime host has to anticipate the static imports that follow. There is no type or invariant enforcing this — it lives entirely in the head of whoever wrote each optimization pass. Forgetting it silently introduces a circular import, which is exactly the bug in rolldown#9401. **Planned follow-up.** A subsequent PR will restructure this: split the runtime module into a standalone chunk during optimization, then merge it into an existing chunk as a final step *after* helper usages are attached. Optimization will then see a complete graph, and the kind of ad-hoc guarding rolldown#9514 added can be removed.

@kylecannon

## [1.0.3] - 2026-05-27 ### 🚀 Features - transform: respect decorator strictNullChecks option (#9580) by @kylecannon - drop `defer` keyword (#9503) by @TheAlexLichter ### 🐛 Bug Fixes - ci: create target dir before cargo release-oxc update (#9584) by @shulaoda - ci: reorder prepare-release steps to avoid dirty git check failure (#9583) by @shulaoda - testing: canonicalize temp dir early and use platform-specific separator in test262 (#9582) by @shulaoda - testing: resolve symlinked temp dir in test262 snapshot normalization (#9581) by @shulaoda - testing: canonicalize temp dir path in test262 snapshot normalization (#9579) by @shulaoda - dev: `onOutput` called twice when initial build fails (#9552) by @hyf0 - dev: make `ensureCurrentBuildFinish` not returning error when engine closes (#9564) by @h-a-n-a - oxc-runtime: route require() to CJS helper variant (#9263) (#9526) by @IWANABETHATGUY - generator: use exporter chunk's export mode for CJS default re-exports (#9299) (#9529) by @IWANABETHATGUY - rolldown: always run reduced-atom static cycle check (#9441) (#9514) by @IWANABETHATGUY - apply transform.dropLabels before scanning (#9521) (#9522) by @IWANABETHATGUY - rolldown_watcher: take `rolldown` dep through the workspace (#9510) by @Boshen - cache: keep the scan-stage cache consistent when a build fails (#9495) by @h-a-n-a - skip JSON default-import namespace optimization for write targets (#9484) (#9489) by @IWANABETHATGUY - deps: skip pnpm frozen-lockfile on Netlify to dodge catalog mismatch bug (#9471) by @Boshen ### 🚜 Refactor - oxc-runtime: use Cow for helper path construction (#9538) by @IWANABETHATGUY - fold import defer phase drop into PreProcessor (#9524) by @IWANABETHATGUY - distinguish `map: null` vs `map: undefined` in transform hook output (#9497) by @sapphi-red ### 📚 Documentation - explain the policy for Rust crates (#9547) by @sapphi-red - cache: add design doc for cache (#9544) by @h-a-n-a - guide/troubleshooting: add TDZ error section (#9537) by @sapphi-red - dev-engine: add design doc for dev-engine (#9479) by @h-a-n-a - lazy-barrel: tweak some words (#9483) by @shulaoda - lazy-barrel: expand reasoning behind LARGE_BARREL_MODULES advice (#9477) by @shulaoda ### ⚡ Performance - generate: thread ast_table by value into codegen consumer (#9555) by @Boshen - finalizers: replace `_reExport` construction with a direct call to avoid calling `clone_in` (#9501) by @Dunqing - reorder hot-path boolean checks to short-circuit on cheap predicates first (#9523) by @Boshen ### 🧪 Testing - rolldown: regression fixture for #9401 (#9418) by @IWANABETHATGUY - failing test for #9441 (#9504) by @TheAlexLichter ### ⚙️ Miscellaneous Tasks - deps: upgrade oxc to 0.133.0 (#9563) by @Dunqing - deps: update crate-ci/typos action to v1.46.3 (#9576) by @renovate[bot] - deps: update mimalloc-safe to 0.1.62 (#9577) by @shulaoda - mimalloc-safe: update to a bug-fix branch for verification (#9569) by @shulaoda - deps: update test262 submodule for tests (#9551) by @rolldown-guard[bot] - point published crates' readme to root README.md (#9553) by @Boshen - replace actions-cool/issues-helper with gh CLI (#9543) by @Boshen - deps: update cargo-shear to 1.12.4 (#9541) by @Boshen - deps: update taiki-e/install-action action to v2.79.4 (#9535) by @renovate[bot] - deps: update github actions (#9532) by @renovate[bot] - deps: update rust crates (#9534) by @renovate[bot] - deps: update npm packages (#9533) by @renovate[bot] - gate experimental/testing-only items to silence dead_code in publish builds (#9517) by @Boshen - docs: deploy to Void (#9509) by @Boshen - release: set up cargo-release-oxc for publishing crates (#9476) by @Boshen - rolldown_plugin_lazy_compilation: add missing description (#9507) by @Boshen - mimalloc-safe: update to a bug-fix branch for verification (#9506) by @shulaoda - deps: update crate-ci/typos action to v1.46.2 (#9468) by @renovate[bot] ### ❤️ New Contributors * @kylecannon made their first contribution in [#9580](#9580)

@kylecannon

## [1.0.3] - 2026-05-27 ### 🚀 Features - transform: respect decorator strictNullChecks option (#9580) by @kylecannon - drop `defer` keyword (#9503) by @TheAlexLichter ### 🐛 Bug Fixes - ci: create target dir before cargo release-oxc update (#9584) by @shulaoda - ci: reorder prepare-release steps to avoid dirty git check failure (#9583) by @shulaoda - testing: canonicalize temp dir early and use platform-specific separator in test262 (#9582) by @shulaoda - testing: resolve symlinked temp dir in test262 snapshot normalization (#9581) by @shulaoda - testing: canonicalize temp dir path in test262 snapshot normalization (#9579) by @shulaoda - dev: `onOutput` called twice when initial build fails (#9552) by @hyf0 - dev: make `ensureCurrentBuildFinish` not returning error when engine closes (#9564) by @h-a-n-a - oxc-runtime: route require() to CJS helper variant (#9263) (#9526) by @IWANABETHATGUY - generator: use exporter chunk's export mode for CJS default re-exports (#9299) (#9529) by @IWANABETHATGUY - rolldown: always run reduced-atom static cycle check (#9441) (#9514) by @IWANABETHATGUY - apply transform.dropLabels before scanning (#9521) (#9522) by @IWANABETHATGUY - rolldown_watcher: take `rolldown` dep through the workspace (#9510) by @Boshen - cache: keep the scan-stage cache consistent when a build fails (#9495) by @h-a-n-a - skip JSON default-import namespace optimization for write targets (#9484) (#9489) by @IWANABETHATGUY - deps: skip pnpm frozen-lockfile on Netlify to dodge catalog mismatch bug (#9471) by @Boshen ### 🚜 Refactor - oxc-runtime: use Cow for helper path construction (#9538) by @IWANABETHATGUY - fold import defer phase drop into PreProcessor (#9524) by @IWANABETHATGUY - distinguish `map: null` vs `map: undefined` in transform hook output (#9497) by @sapphi-red ### 📚 Documentation - explain the policy for Rust crates (#9547) by @sapphi-red - cache: add design doc for cache (#9544) by @h-a-n-a - guide/troubleshooting: add TDZ error section (#9537) by @sapphi-red - dev-engine: add design doc for dev-engine (#9479) by @h-a-n-a - lazy-barrel: tweak some words (#9483) by @shulaoda - lazy-barrel: expand reasoning behind LARGE_BARREL_MODULES advice (#9477) by @shulaoda ### ⚡ Performance - generate: thread ast_table by value into codegen consumer (#9555) by @Boshen - finalizers: replace `_reExport` construction with a direct call to avoid calling `clone_in` (#9501) by @Dunqing - reorder hot-path boolean checks to short-circuit on cheap predicates first (#9523) by @Boshen ### 🧪 Testing - rolldown: regression fixture for #9401 (#9418) by @IWANABETHATGUY - failing test for #9441 (#9504) by @TheAlexLichter ### ⚙️ Miscellaneous Tasks - deps: upgrade oxc to 0.133.0 (#9563) by @Dunqing - deps: update crate-ci/typos action to v1.46.3 (#9576) by @renovate[bot] - deps: update mimalloc-safe to 0.1.62 (#9577) by @shulaoda - mimalloc-safe: update to a bug-fix branch for verification (#9569) by @shulaoda - deps: update test262 submodule for tests (#9551) by @rolldown-guard[bot] - point published crates' readme to root README.md (#9553) by @Boshen - replace actions-cool/issues-helper with gh CLI (#9543) by @Boshen - deps: update cargo-shear to 1.12.4 (#9541) by @Boshen - deps: update taiki-e/install-action action to v2.79.4 (#9535) by @renovate[bot] - deps: update github actions (#9532) by @renovate[bot] - deps: update rust crates (#9534) by @renovate[bot] - deps: update npm packages (#9533) by @renovate[bot] - gate experimental/testing-only items to silence dead_code in publish builds (#9517) by @Boshen - docs: deploy to Void (#9509) by @Boshen - release: set up cargo-release-oxc for publishing crates (#9476) by @Boshen - rolldown_plugin_lazy_compilation: add missing description (#9507) by @Boshen - mimalloc-safe: update to a bug-fix branch for verification (#9506) by @shulaoda - deps: update crate-ci/typos action to v1.46.2 (#9468) by @renovate[bot] ### ❤️ New Contributors * @kylecannon made their first contribution in [#9580](#9580)

github-actions Bot assigned IWANABETHATGUY May 22, 2026

IWANABETHATGUY force-pushed the 05-22-fix_9441-cd branch from 518be36 to 4e99115 Compare May 22, 2026 10:04

IWANABETHATGUY changed the title ~~fix: 9441-cd~~ fix(rolldown): always run reduced-atom static cycle check (#9441) May 22, 2026

IWANABETHATGUY force-pushed the 05-22-fix_9441-cd branch from b253c58 to 65712e1 Compare May 22, 2026 10:11

IWANABETHATGUY added the trigger: preview label May 22, 2026

IWANABETHATGUY mentioned this pull request May 22, 2026

fix: align dynamic already-loaded reduction with Rollup #9518

Draft

IWANABETHATGUY marked this pull request as ready for review May 22, 2026 15:15

IWANABETHATGUY requested review from h-a-n-a, hyf0 and shulaoda May 22, 2026 15:15

hyf0 approved these changes May 24, 2026

View reviewed changes

IWANABETHATGUY added the graphite: merge-when-ready label May 24, 2026

IWANABETHATGUY force-pushed the 05-22-fix_9441-cd branch from 65712e1 to 6b670df Compare May 24, 2026 02:53

graphite-app Bot force-pushed the 05-22-fix_9441-cd branch from 6b670df to 7ae80f0 Compare May 24, 2026 02:53

graphite-app Bot merged commit 7ae80f0 into main May 24, 2026
33 checks passed

graphite-app Bot removed the graphite: merge-when-ready label May 24, 2026

graphite-app Bot deleted the 05-22-fix_9441-cd branch May 24, 2026 02:58

graphite-app Bot temporarily deployed to void May 24, 2026 03:00 Inactive

IWANABETHATGUY mentioned this pull request May 25, 2026

test(rolldown): regression fixture for #9401 #9418

Merged

rolldown-guard Bot mentioned this pull request May 27, 2026

release: v1.0.3 for rust crates #9585

Merged

shulaoda mentioned this pull request May 27, 2026

release: v1.0.3 #9586

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(rolldown): always run reduced-atom static cycle check (#9441)#9514

fix(rolldown): always run reduced-atom static cycle check (#9441)#9514
graphite-app[bot] merged 1 commit into
mainfrom
05-22-fix_9441-cd

IWANABETHATGUY commented May 22, 2026 •

edited

Loading

Uh oh!

IWANABETHATGUY commented May 22, 2026 •

edited

Loading

Uh oh!

netlify Bot commented May 22, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented May 22, 2026

Uh oh!

codspeed-hq Bot commented May 22, 2026

Uh oh!

IWANABETHATGUY commented May 24, 2026 •

edited by graphite-app Bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

IWANABETHATGUY commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IWANABETHATGUY commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

netlify Bot commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

pkg-pr-new Bot commented May 22, 2026

Uh oh!

codspeed-hq Bot commented May 22, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

IWANABETHATGUY commented May 24, 2026 • edited by graphite-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IWANABETHATGUY commented May 22, 2026 •

edited

Loading

IWANABETHATGUY commented May 22, 2026 •

edited

Loading

netlify Bot commented May 22, 2026 •

edited

Loading

IWANABETHATGUY commented May 24, 2026 •

edited by graphite-app Bot

Loading