fix: sanitize preserveModules chunk names from query ids#9289
Open
deltama37 wants to merge 5 commits into
Open
fix: sanitize preserveModules chunk names from query ids#9289deltama37 wants to merge 5 commits into
deltama37 wants to merge 5 commits into
Conversation
Merging this PR will not alter performance
Comparing 
Footnotes
|
sapphi-red
requested changes
May 19, 2026
sapphi-red
left a comment
sapphi-red
left a comment
Member
There was a problem hiding this comment.
Please add the tests from #8817 and address the comments there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8761.
When
output.preserveModulesis enabled, Rolldown derives chunk names from module ids. For query-bearing module ids such as Vue SFC submodules:the generated JS chunk name could keep
?,&, and=in the output filename when using object-form entries.This change applies the existing
sanitizeFileNamelogic after the preserveModules chunk name has been assembled, so the emitted filename becomes:Test
Added a Node fixture covering a preserveModules build with an object-form entry and a Vue-style query module id.