docs: design doc for reference_needed_symbols#9264
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label graphite: merge-when-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
IWANABETHATGUY
changed the base branch from
04-28-docs_determine_module_exports_kind
to
graphite-base/9264
April 29, 2026 12:23
IWANABETHATGUY
force-pushed
the
04-29-docs_reference_needed_symbols
branch
from
April 29, 2026 12:23
8b5ffdd to
fb5d22e
Compare
IWANABETHATGUY
force-pushed
the
graphite-base/9264
branch
from
April 29, 2026 12:23
1165f21 to
1cc9a48
Compare
IWANABETHATGUY
changed the base branch from
graphite-base/9264
to
04-27-fix_avoid_unsafe_in_determine_module_exports_kind
April 29, 2026 12:23
graphite-app
Bot
force-pushed
the
04-27-fix_avoid_unsafe_in_determine_module_exports_kind
branch
2 times, most recently
from
April 29, 2026 13:03
1f8cd40 to
f3496ae
Compare
graphite-app
Bot
force-pushed
the
04-29-docs_reference_needed_symbols
branch
from
April 29, 2026 13:03
fb5d22e to
54f5bef
Compare
IWANABETHATGUY
force-pushed
the
04-29-docs_reference_needed_symbols
branch
from
April 29, 2026 15:46
54f5bef to
703195f
Compare
graphite-app
Bot
changed the base branch from
04-27-fix_avoid_unsafe_in_determine_module_exports_kind
to
graphite-base/9264
April 29, 2026 15:56
graphite-app
Bot
force-pushed
the
graphite-base/9264
branch
from
April 29, 2026 16:01
1c19c64 to
92c9230
Compare
graphite-app
Bot
force-pushed
the
04-29-docs_reference_needed_symbols
branch
from
April 29, 2026 16:01
703195f to
119d78c
Compare
graphite-app
Bot
force-pushed
the
04-29-docs_reference_needed_symbols
branch
from
April 29, 2026 16:02
119d78c to
30538df
Compare
✅ Deploy Preview for rolldown-rs canceled.
|
IWANABETHATGUY
force-pushed
the
04-29-docs_reference_needed_symbols
branch
from
April 29, 2026 16:20
30538df to
0ef96a7
Compare
IWANABETHATGUY
changed the title
IWANABETHATGUY
force-pushed
the
04-29-docs_reference_needed_symbols
branch
from
April 29, 2026 17:04
2072862 to
9d8a01c
Compare
IWANABETHATGUY
marked this pull request as ready for review
April 30, 2026 02:15
Merging this PR will not alter performance
Comparing 
Footnotes
|
shulaoda
approved these changes
Apr 30, 2026
Member
Author
Merge activity
|
Adds a design doc for the `reference_needed_symbols` link-stage pass under `meta/design/linking/`, covering pipeline placement, dispatch rules (by import kind / module kind / wrap kind / reexport flag), the invariants `include_statements` relies on, and implementation constraints (parallel-mutation casts on `stmt_infos`/`depended_runtime_helper`, and the deferred `record_meta_pairs` defer-list). Also corrects a stale comment in `code_splitting.rs` — `safely_merge_cjs_ns_map` is populated by `determine_safely_merge_cjs_ns`, not by `reference_needed_symbols`.
graphite-app
Bot
force-pushed
the
04-29-docs_reference_needed_symbols
branch
from
April 30, 2026 04:59
9d8a01c to
5eecace
Compare
Merged
shulaoda
added a commit
that referenced
this pull request
May 7, 2026
## [1.0.0] - 2026-05-07 ### 🐛 Bug Fixes - dev/lazy: lazily compiled modules should be watched (#9301) by @h-a-n-a - implement dynamic dominator merge logic (#9270) by @TheAlexLichter - dev: apply __toCommonJS interop when CJS requires ESM in HMR finalizer (#9261) by @h-a-n-a ### 🚜 Refactor - ecma_ast: tighten allocator access to enforce Sync invariant (#9278) by @IWANABETHATGUY - scan_stage: remove stmt_infos field from EcmaView (#9276) by @IWANABETHATGUY - link_stage: detach stmt_infos from EcmaView (#9274) by @IWANABETHATGUY - link_stage: detach depended_runtime_helper from EcmaView to remove unsafe (#9265) by @IWANABETHATGUY - link_stage: remove unsafe in determine_module_exports_kind (#9253) by @IWANABETHATGUY ### 📚 Documentation - getting-started: remove RC warning for 1.0.0 release (#9310) by @shulaoda - getting-started: update version references for 1.0.0 release (#9309) by @shulaoda - add Vite+ tab to getting-started snippets (#9285) by @shulaoda - lazy-barrel: clarify own-exports behavior for import-then-export records (#9298) by @shulaoda - restructure top navigation around Learn vs Reference (#9284) by @shulaoda - builtin-plugins: add bundle analyzer plugin docs (#9292) by @shulaoda - design doc for reference_needed_symbols (#9264) by @IWANABETHATGUY ### ⚡ Performance - devtools: write logs on a background thread (#9219) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - mark esbuild/ts/parameter_props_use_define_for_class_fields_true as passed (#9308) by @sapphi-red - deps: upgrade oxc to 0.129.0 (#9297) by @shulaoda - deps: update rollup submodule for tests to v4.60.3 (#9294) by @sapphi-red - deps: update test262 submodule for tests (#9295) by @sapphi-red - ai: add rolldown REPL decode skill (#9245) by @Dunqing
pull Bot
pushed a commit
to olrtg/rolldown
that referenced
this pull request
May 7, 2026
## [1.0.0] - 2026-05-07 ### 🐛 Bug Fixes - dev/lazy: lazily compiled modules should be watched (rolldown#9301) by @h-a-n-a - implement dynamic dominator merge logic (rolldown#9270) by @TheAlexLichter - dev: apply __toCommonJS interop when CJS requires ESM in HMR finalizer (rolldown#9261) by @h-a-n-a ### 🚜 Refactor - ecma_ast: tighten allocator access to enforce Sync invariant (rolldown#9278) by @IWANABETHATGUY - scan_stage: remove stmt_infos field from EcmaView (rolldown#9276) by @IWANABETHATGUY - link_stage: detach stmt_infos from EcmaView (rolldown#9274) by @IWANABETHATGUY - link_stage: detach depended_runtime_helper from EcmaView to remove unsafe (rolldown#9265) by @IWANABETHATGUY - link_stage: remove unsafe in determine_module_exports_kind (rolldown#9253) by @IWANABETHATGUY ### 📚 Documentation - getting-started: remove RC warning for 1.0.0 release (rolldown#9310) by @shulaoda - getting-started: update version references for 1.0.0 release (rolldown#9309) by @shulaoda - add Vite+ tab to getting-started snippets (rolldown#9285) by @shulaoda - lazy-barrel: clarify own-exports behavior for import-then-export records (rolldown#9298) by @shulaoda - restructure top navigation around Learn vs Reference (rolldown#9284) by @shulaoda - builtin-plugins: add bundle analyzer plugin docs (rolldown#9292) by @shulaoda - design doc for reference_needed_symbols (rolldown#9264) by @IWANABETHATGUY ### ⚡ Performance - devtools: write logs on a background thread (rolldown#9219) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - mark esbuild/ts/parameter_props_use_define_for_class_fields_true as passed (rolldown#9308) by @sapphi-red - deps: upgrade oxc to 0.129.0 (rolldown#9297) by @shulaoda - deps: update rollup submodule for tests to v4.60.3 (rolldown#9294) by @sapphi-red - deps: update test262 submodule for tests (rolldown#9295) by @sapphi-red - ai: add rolldown REPL decode skill (rolldown#9245) by @Dunqing Co-authored-by: shulaoda <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a design doc for the
reference_needed_symbolslink-stage pass undermeta/design/linking/, covering pipeline placement, dispatch rules (by import kind / module kind / wrap kind / reexport flag), the invariantsinclude_statementsrelies on, and implementation constraints (parallel-mutation casts onstmt_infos/depended_runtime_helper, and the deferredrecord_meta_pairsdefer-list). Also corrects a stale comment incode_splitting.rs—safely_merge_cjs_ns_mapis populated bydetermine_safely_merge_cjs_ns, not byreference_needed_symbols.