refactor(link_stage): remove unsafe in determine_module_exports_kind#9253
Merged
graphite-app[bot] merged 1 commit intoApr 29, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label graphite: merge-when-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
IWANABETHATGUY
changed the title
This was referenced Apr 29, 2026
IWANABETHATGUY
force-pushed
the
04-28-docs_determine_module_exports_kind
branch
from
April 29, 2026 12:23
1165f21 to
a6ebf91
Compare
IWANABETHATGUY
force-pushed
the
04-27-fix_avoid_unsafe_in_determine_module_exports_kind
branch
from
April 29, 2026 12:23
4cf1bb0 to
1cc9a48
Compare
graphite-app
Bot
changed the base branch from
04-28-docs_determine_module_exports_kind
to
graphite-base/9253
April 29, 2026 13:01
graphite-app
Bot
force-pushed
the
04-27-fix_avoid_unsafe_in_determine_module_exports_kind
branch
from
April 29, 2026 13:02
1cc9a48 to
1f8cd40
Compare
graphite-app
Bot
force-pushed
the
graphite-base/9253
branch
from
April 29, 2026 13:02
a6ebf91 to
c5e62cd
Compare
graphite-app
Bot
force-pushed
the
04-27-fix_avoid_unsafe_in_determine_module_exports_kind
branch
from
April 29, 2026 13:03
1f8cd40 to
f3496ae
Compare
✅ Deploy Preview for rolldown-rs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
IWANABETHATGUY
marked this pull request as ready for review
April 29, 2026 15:52
h-a-n-a
approved these changes
Apr 29, 2026
Contributor
Merge activity
|
…9253) Replaces the three `unsafe { addr_of!(*importee).cast_mut() }` blocks in `determine_module_exports_kind` with index-based iteration that releases the `module_table` borrow before each `as_normal_mut()` mutation. Reads and writes still interleave in the same order as the original closure walk, so behavior is preserved bit-for-bit — no fixture snapshots are touched.
graphite-app
Bot
force-pushed
the
04-27-fix_avoid_unsafe_in_determine_module_exports_kind
branch
from
April 29, 2026 15:56
1c19c64 to
92c9230
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the link stage’s determine_module_exports_kind pass to eliminate unsafe pointer-based mutation by restructuring iteration so module_table borrows don’t overlap with as_normal_mut() mutations. This keeps the same promotion/wrapping semantics while making the code borrow-checker-friendly.
Changes:
- Removed
unsafe { addr_of!(...).cast_mut() }mutations ofexports_kind. - Reworked the walk over importers/import records to use index-based iteration and short immutable borrows before each mutation.
- Updated imports to use
ImportRecordIdxfor index-based access.
Comment on lines
+17
to
+23
| let importer_indices: Vec<_> = self | ||
| .module_table | ||
| .modules | ||
| .iter_enumerated() | ||
| .filter_map(|(idx, m)| matches!(m, Module::Normal(_)).then_some(idx)) | ||
| .collect(); | ||
|
|
Comment on lines
+25
to
+36
| let n_records = match &self.module_table[importer_idx] { | ||
| Module::Normal(m) => m.import_records.len(), | ||
| Module::External(_) => continue, | ||
| }; | ||
|
|
||
| for rec_pos in 0..n_records { | ||
| let (kind, importee_idx) = { | ||
| let Module::Normal(m) = &self.module_table[importer_idx] else { continue }; | ||
| let rec = &m.import_records[ImportRecordIdx::from_usize(rec_pos)]; | ||
| let Some(importee_idx) = rec.resolved_module else { continue }; | ||
| (rec.kind, importee_idx) | ||
| }; |
graphite-app
Bot
deleted the
04-27-fix_avoid_unsafe_in_determine_module_exports_kind
branch
April 29, 2026 16:01
Merging this PR will not alter performance
Comparing 
Footnotes
|
Closed
Merged
Merged
shulaoda
added a commit
that referenced
this pull request
May 7, 2026
## [1.0.0] - 2026-05-07 ### 🐛 Bug Fixes - dev/lazy: lazily compiled modules should be watched (#9301) by @h-a-n-a - implement dynamic dominator merge logic (#9270) by @TheAlexLichter - dev: apply __toCommonJS interop when CJS requires ESM in HMR finalizer (#9261) by @h-a-n-a ### 🚜 Refactor - ecma_ast: tighten allocator access to enforce Sync invariant (#9278) by @IWANABETHATGUY - scan_stage: remove stmt_infos field from EcmaView (#9276) by @IWANABETHATGUY - link_stage: detach stmt_infos from EcmaView (#9274) by @IWANABETHATGUY - link_stage: detach depended_runtime_helper from EcmaView to remove unsafe (#9265) by @IWANABETHATGUY - link_stage: remove unsafe in determine_module_exports_kind (#9253) by @IWANABETHATGUY ### 📚 Documentation - getting-started: remove RC warning for 1.0.0 release (#9310) by @shulaoda - getting-started: update version references for 1.0.0 release (#9309) by @shulaoda - add Vite+ tab to getting-started snippets (#9285) by @shulaoda - lazy-barrel: clarify own-exports behavior for import-then-export records (#9298) by @shulaoda - restructure top navigation around Learn vs Reference (#9284) by @shulaoda - builtin-plugins: add bundle analyzer plugin docs (#9292) by @shulaoda - design doc for reference_needed_symbols (#9264) by @IWANABETHATGUY ### ⚡ Performance - devtools: write logs on a background thread (#9219) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - mark esbuild/ts/parameter_props_use_define_for_class_fields_true as passed (#9308) by @sapphi-red - deps: upgrade oxc to 0.129.0 (#9297) by @shulaoda - deps: update rollup submodule for tests to v4.60.3 (#9294) by @sapphi-red - deps: update test262 submodule for tests (#9295) by @sapphi-red - ai: add rolldown REPL decode skill (#9245) by @Dunqing
pull Bot
pushed a commit
to olrtg/rolldown
that referenced
this pull request
May 7, 2026
## [1.0.0] - 2026-05-07 ### 🐛 Bug Fixes - dev/lazy: lazily compiled modules should be watched (rolldown#9301) by @h-a-n-a - implement dynamic dominator merge logic (rolldown#9270) by @TheAlexLichter - dev: apply __toCommonJS interop when CJS requires ESM in HMR finalizer (rolldown#9261) by @h-a-n-a ### 🚜 Refactor - ecma_ast: tighten allocator access to enforce Sync invariant (rolldown#9278) by @IWANABETHATGUY - scan_stage: remove stmt_infos field from EcmaView (rolldown#9276) by @IWANABETHATGUY - link_stage: detach stmt_infos from EcmaView (rolldown#9274) by @IWANABETHATGUY - link_stage: detach depended_runtime_helper from EcmaView to remove unsafe (rolldown#9265) by @IWANABETHATGUY - link_stage: remove unsafe in determine_module_exports_kind (rolldown#9253) by @IWANABETHATGUY ### 📚 Documentation - getting-started: remove RC warning for 1.0.0 release (rolldown#9310) by @shulaoda - getting-started: update version references for 1.0.0 release (rolldown#9309) by @shulaoda - add Vite+ tab to getting-started snippets (rolldown#9285) by @shulaoda - lazy-barrel: clarify own-exports behavior for import-then-export records (rolldown#9298) by @shulaoda - restructure top navigation around Learn vs Reference (rolldown#9284) by @shulaoda - builtin-plugins: add bundle analyzer plugin docs (rolldown#9292) by @shulaoda - design doc for reference_needed_symbols (rolldown#9264) by @IWANABETHATGUY ### ⚡ Performance - devtools: write logs on a background thread (rolldown#9219) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - mark esbuild/ts/parameter_props_use_define_for_class_fields_true as passed (rolldown#9308) by @sapphi-red - deps: upgrade oxc to 0.129.0 (rolldown#9297) by @shulaoda - deps: update rollup submodule for tests to v4.60.3 (rolldown#9294) by @sapphi-red - deps: update test262 submodule for tests (rolldown#9295) by @sapphi-red - ai: add rolldown REPL decode skill (rolldown#9245) by @Dunqing Co-authored-by: shulaoda <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the three
unsafe { addr_of!(*importee).cast_mut() }blocks indetermine_module_exports_kindwith index-based iteration that releases themodule_tableborrow before eachas_normal_mut()mutation. Reads and writes still interleave in the same order as the original closure walk, so behavior is preserved bit-for-bit — no fixture snapshots are touched.