Skip to content

fix(rolldown_plugin_lazy_compilation): escape request ID in proxy modules #9102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Apr 14, 2026
Merged

fix(rolldown_plugin_lazy_compilation): escape request ID in proxy modules #9102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/rolldown_plugin_lazy_compilation/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ rolldown_common = { workspace = true }
rolldown_plugin = { workspace = true }
rolldown_utils = { workspace = true }
anyhow = { workspace = true }
serde_json = { workspace = true }

[lints]
workspace = true

[lib]
test = false
doctest = false
53 changes: 45 additions & 8 deletions crates/rolldown_plugin_lazy_compilation/src/lazy_compilation_plugin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,14 +152,7 @@ impl Plugin for LazyCompilationPlugin {
// The proxy module ID includes the ?rolldown-lazy=1 suffix
let proxy_id = args.id;

// Replace placeholders in order: longer ones first to avoid partial matches
// $PROXY_MODULE_ID and $STABLE_MODULE_ID contain "MODULE_ID" as substring

// // TODO: hyf0 prevent xss vulnerabilities by escaping IDs properly
let code = template
.replace("$PROXY_MODULE_ID", &format!("\"{proxy_id}\""))
.replace("$STABLE_MODULE_ID", &format!("\"{}\"", stable_id.as_str()))
.replace("$MODULE_ID", &format!("\"{original_id}\""));
let code = render_proxy_template(template, proxy_id, stable_id.as_str(), original_id)?;
return Ok(Some(rolldown_plugin::HookLoadOutput {
code: ArcStr::from(code),
..Default::default()
Expand Down Expand Up @@ -204,3 +197,47 @@ impl Plugin for LazyCompilationPlugin {
Ok(args.ast)
}
}

// Replace placeholders in order: longer ones first to avoid partial matches
// $PROXY_MODULE_ID and $STABLE_MODULE_ID contain "MODULE_ID" as substring
fn render_proxy_template(
template: &str,
proxy_id: &str,
stable_id: &str,
original_id: &str,
) -> serde_json::Result<String> {
Ok(
template
.replace("$PROXY_MODULE_ID", &serde_json::to_string(proxy_id)?)
.replace("$STABLE_MODULE_ID", &serde_json::to_string(stable_id)?)
.replace("$MODULE_ID", &serde_json::to_string(original_id)?),
)
}

#[cfg(test)]
mod tests {
use super::render_proxy_template;

#[test]
fn windows_path() {
let proxy_id = r"D:\Users\foo\bar\baz.js?rolldown-lazy=1";
let stable_id = r"src\bar\baz.js";
let original_id = r"D:\Users\foo\bar\baz.js";

let template = "P=$PROXY_MODULE_ID;S=$STABLE_MODULE_ID;M=$MODULE_ID;";
let rendered = render_proxy_template(template, proxy_id, stable_id, original_id).unwrap();

assert_eq!(
rendered,
r#"P="D:\\Users\\foo\\bar\\baz.js?rolldown-lazy=1";S="src\\bar\\baz.js";M="D:\\Users\\foo\\bar\\baz.js";"#
);
}

#[test]
fn unix_path() {
let id = "/Users/foo/bar.js?rolldown-lazy=1";
let rendered =
render_proxy_template("$PROXY_MODULE_ID", id, "src/bar.js", "/Users/foo/bar.js").unwrap();
assert_eq!(rendered, "\"/Users/foo/bar.js?rolldown-lazy=1\"");
}
}
Loading