Skip to content

refactor: cleanup and simplify in dynamic_import.rs#8927

Merged
hyf0 merged 1 commit intorolldown:mainfrom
ulrichstark:cleanup-and-simplify-dynamic-import
Mar 29, 2026
Merged

refactor: cleanup and simplify in dynamic_import.rs#8927
hyf0 merged 1 commit intorolldown:mainfrom
ulrichstark:cleanup-and-simplify-dynamic-import

Conversation

@ulrichstark
Copy link
Copy Markdown
Contributor

  • extract duplicate code out of match arms
  • bail out earlier if it's not a StaticMemberExpression with property name then to shorten code and avoid unwrap
  • refactor out dummy return value of init_dynamic_import_binding_usage_info

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 26, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 10 skipped benchmarks1


Comparing ulrichstark:cleanup-and-simplify-dynamic-import (5c635f4) with main (2e68d31)

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Boshen Boshen requested a review from IWANABETHATGUY March 27, 2026 03:01
@IWANABETHATGUY IWANABETHATGUY force-pushed the cleanup-and-simplify-dynamic-import branch from afffe87 to 817866e Compare March 27, 2026 06:39
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 27, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 5c635f4
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/69c8fc12a44afe0008ad4d48

@ulrichstark
Copy link
Copy Markdown
Contributor Author

I can't reproduce the CI failure locally and it's probably not related to my change. Or is there anything I can do?

@ulrichstark ulrichstark requested a review from hyf0 March 28, 2026 08:45
@IWANABETHATGUY IWANABETHATGUY force-pushed the cleanup-and-simplify-dynamic-import branch from 817866e to 5c635f4 Compare March 29, 2026 10:16
@hyf0
Copy link
Copy Markdown
Member

hyf0 commented Mar 29, 2026

Thank you!

@hyf0 hyf0 merged commit f51c52d into rolldown:main Mar 29, 2026
31 checks passed
@ulrichstark ulrichstark deleted the cleanup-and-simplify-dynamic-import branch March 29, 2026 11:52
This was referenced Apr 1, 2026
shulaoda added a commit that referenced this pull request Apr 1, 2026
## [1.0.0-rc.13] - 2026-04-01

### 🚀 Features

- add friendly error for unloadable virtual modules (#8955) by @sapphi-red
- better error message for unsupported CSS error (#8911) by @sapphi-red

### 🐛 Bug Fixes

- prevent chunk merging from leaking entry side effects (#8979) by @IWANABETHATGUY
- correct inlining based on module's def format and esModule flag (#8975) by @h-a-n-a
- generate init calls for excluded re-exports in strict execution order (#8858) by @IWANABETHATGUY
- consistent order for `meta.chunks` in `renderChunk` hook (#8956) by @sapphi-red
- subpath imports in glob imports failing to find files (#8885) by @kalvenschraut
- browser: bundle binding types in dts output (#8930) by @nyan-left
- ci: guard artifact download step in `vite-test-ubuntu` when build is skipped (#8934) by @Copilot
- track CJS re-export import records to fix inline const and tree-shaking (#8925) by @h-a-n-a
- use ImportKind::Import for common-chunk root computation (#8899) by @IWANABETHATGUY
- watch: clear emitted_filenames between rebuilds (#8914) by @IWANABETHATGUY
- ci: cache esbuild snapshots to avoid 429 rate limiting (#8921) by @IWANABETHATGUY
- always check circular deps in chunk optimizer (#8915) by @IWANABETHATGUY
- don't mark calls to reassigned bindings as pure (#8917) by @IWANABETHATGUY
- magic-string: throw TypeError for non-string content args (#8905) by @IWANABETHATGUY
- magic-string: add split-point validation and overwrite/update options (#8904) by @IWANABETHATGUY

### 🚜 Refactor

- pre-compute has_side_effects on ChunkCandidate (#8981) by @IWANABETHATGUY
- cleanup and simplify in dynamic_import.rs (#8927) by @ulrichstark
- rename came_from_cjs to came_from_commonjs for consistency (#8938) by @IWANABETHATGUY
- inline `create_ecma_view` return destructuring and remove redundant binding (#8932) by @shulaoda

### 📚 Documentation

- document ensure_lazy_module_initialization_order in code-splitting design doc (#8931) by @IWANABETHATGUY

### 🧪 Testing

- add regression test for runtime helper circular dependency (#8958) by @h-a-n-a
- enable 8 previously-skipped MagicString remove tests (#8945) by @IWANABETHATGUY
- add test for why PureAnnotation is needed in execution order check (#8933) by @IWANABETHATGUY

### ⚙️ Miscellaneous Tasks

- add `@emnapi/runtime` and `@emnapi/core` as direct deps of `@rolldown/browser` (#8978) by @Copilot
- deps: update dependency vite-plus to v0.1.15 (#8970) by @renovate[bot]
- deps: update dependency oxfmt to ^0.43.0 (#8969) by @renovate[bot]
- deps: upgrade oxc to 0.123.0 (#8967) by @shulaoda
- justfile: deduplicate update-submodule as alias of setup-submodule (#8968) by @shulaoda
- deps: update rollup submodule for tests to v4.60.1 (#8965) by @sapphi-red
- deps: update test262 submodule for tests (#8966) by @sapphi-red
- remove unused `type-check` scripts (#8957) by @sapphi-red
- deps: update actions/cache action to v5 (#8953) by @renovate[bot]
- deps: update npm packages to v6 (major) (#8954) by @renovate[bot]
- deps: update npm packages (#8948) by @renovate[bot]
- deps: update rust crates (#8949) by @renovate[bot]
- deps: update github-actions (#8947) by @renovate[bot]
- deps: update napi (#8943) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to ^0.23.0 (#8944) by @renovate[bot]
- regenerate testing snapshots (#8928) by @ulrichstark
- deps: update dependency rust to v1.94.1 (#8923) by @renovate[bot]

### ❤️ New Contributors

* @kalvenschraut made their first contribution in [#8885](#8885)
* @nyan-left made their first contribution in [#8930](#8930)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants