fix: use ImportKind::Import for common-chunk root computation by IWANABETHATGUY · Pull Request #8899 · rolldown/rolldown

IWANABETHATGUY · 2026-03-25T08:06:02Z

Summary

Aligns common-chunk root computation with js_import_order DFS traversal by filtering on ImportKind::Import instead of is_static()
Previously, modules reached only via require() in a common chunk were excluded from roots but never visited by DFS, causing wrapped CJS dependencies to miss the init-order fixup
Generalizes js_import_order to accept multiple roots so common chunks are processed alongside entry chunks

Test plan

Added integration test for issue [Bug]: TinyMCE + Vite 8 (Rolldown) - Module Execution Order Bug #8812 (two entry points sharing CJS modules with require-only edges)
Snapshot verifies require_fake_core() executes before require_fake_plugin_model()

🤖 Generated with Claude Code

IWANABETHATGUY · 2026-03-25T08:06:15Z

fix: use ImportKind::Import for common-chunk root computation #8899 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2026-03-25T08:07:16Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`7f454c8`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69c5ff026e6a20000827e75d

codspeed-hq · 2026-03-26T14:49:48Z

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 10 skipped benchmarks¹

_{Comparing 03-25-fix_8812 (7dd60cb) with main (e9cde37)²}

10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (e0dd665) during the generation of this report, so e9cde37 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

IWANABETHATGUY · 2026-03-27T03:48:26Z

Merge activity

Mar 27, 3:48 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Mar 27, 3:51 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Mar 27, 3:56 AM UTC: Merged by the Graphite merge queue.

## Summary - Aligns common-chunk root computation with `js_import_order` DFS traversal by filtering on `ImportKind::Import` instead of `is_static()` - Previously, modules reached only via `require()` in a common chunk were excluded from roots but never visited by DFS, causing wrapped CJS dependencies to miss the init-order fixup - Generalizes `js_import_order` to accept multiple roots so common chunks are processed alongside entry chunks ## Test plan - [x] Added integration test for issue #8812 (two entry points sharing CJS modules with require-only edges) - [x] Snapshot verifies `require_fake_core()` executes before `require_fake_plugin_model()` 🤖 Generated with [Claude Code](https://claude.com/claude-code)

hyf0 · 2026-03-27T03:52:51Z

crates/rolldown/src/stages/generate_stage/code_splitting.rs

+    chunk_graph.chunk_table.iter_mut().for_each(|chunk| {
+      // Determine DFS roots based on chunk kind.
+      // For entry chunks, the root is the entry module.
+      // For common chunks, roots are modules not imported by any other module in the chunk.


I think you could start to commit design doc about related features so others could understand the flow via doc instead of reading code.

Like I don't get why root modules in the common chunk is defined this way.

@sapphi-red

## [1.0.0-rc.13] - 2026-04-01 ### 🚀 Features - add friendly error for unloadable virtual modules (#8955) by @sapphi-red - better error message for unsupported CSS error (#8911) by @sapphi-red ### 🐛 Bug Fixes - prevent chunk merging from leaking entry side effects (#8979) by @IWANABETHATGUY - correct inlining based on module's def format and esModule flag (#8975) by @h-a-n-a - generate init calls for excluded re-exports in strict execution order (#8858) by @IWANABETHATGUY - consistent order for `meta.chunks` in `renderChunk` hook (#8956) by @sapphi-red - subpath imports in glob imports failing to find files (#8885) by @kalvenschraut - browser: bundle binding types in dts output (#8930) by @nyan-left - ci: guard artifact download step in `vite-test-ubuntu` when build is skipped (#8934) by @Copilot - track CJS re-export import records to fix inline const and tree-shaking (#8925) by @h-a-n-a - use ImportKind::Import for common-chunk root computation (#8899) by @IWANABETHATGUY - watch: clear emitted_filenames between rebuilds (#8914) by @IWANABETHATGUY - ci: cache esbuild snapshots to avoid 429 rate limiting (#8921) by @IWANABETHATGUY - always check circular deps in chunk optimizer (#8915) by @IWANABETHATGUY - don't mark calls to reassigned bindings as pure (#8917) by @IWANABETHATGUY - magic-string: throw TypeError for non-string content args (#8905) by @IWANABETHATGUY - magic-string: add split-point validation and overwrite/update options (#8904) by @IWANABETHATGUY ### 🚜 Refactor - pre-compute has_side_effects on ChunkCandidate (#8981) by @IWANABETHATGUY - cleanup and simplify in dynamic_import.rs (#8927) by @ulrichstark - rename came_from_cjs to came_from_commonjs for consistency (#8938) by @IWANABETHATGUY - inline `create_ecma_view` return destructuring and remove redundant binding (#8932) by @shulaoda ### 📚 Documentation - document ensure_lazy_module_initialization_order in code-splitting design doc (#8931) by @IWANABETHATGUY ### 🧪 Testing - add regression test for runtime helper circular dependency (#8958) by @h-a-n-a - enable 8 previously-skipped MagicString remove tests (#8945) by @IWANABETHATGUY - add test for why PureAnnotation is needed in execution order check (#8933) by @IWANABETHATGUY ### ⚙️ Miscellaneous Tasks - add `@emnapi/runtime` and `@emnapi/core` as direct deps of `@rolldown/browser` (#8978) by @Copilot - deps: update dependency vite-plus to v0.1.15 (#8970) by @renovate[bot] - deps: update dependency oxfmt to ^0.43.0 (#8969) by @renovate[bot] - deps: upgrade oxc to 0.123.0 (#8967) by @shulaoda - justfile: deduplicate update-submodule as alias of setup-submodule (#8968) by @shulaoda - deps: update rollup submodule for tests to v4.60.1 (#8965) by @sapphi-red - deps: update test262 submodule for tests (#8966) by @sapphi-red - remove unused `type-check` scripts (#8957) by @sapphi-red - deps: update actions/cache action to v5 (#8953) by @renovate[bot] - deps: update npm packages to v6 (major) (#8954) by @renovate[bot] - deps: update npm packages (#8948) by @renovate[bot] - deps: update rust crates (#8949) by @renovate[bot] - deps: update github-actions (#8947) by @renovate[bot] - deps: update napi (#8943) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to ^0.23.0 (#8944) by @renovate[bot] - regenerate testing snapshots (#8928) by @ulrichstark - deps: update dependency rust to v1.94.1 (#8923) by @renovate[bot] ### ❤️ New Contributors * @kalvenschraut made their first contribution in [#8885](#8885) * @nyan-left made their first contribution in [#8930](#8930) Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned IWANABETHATGUY Mar 25, 2026

IWANABETHATGUY force-pushed the 03-25-fix_8812 branch 2 times, most recently from 142cb48 to 22026f0 Compare March 25, 2026 08:47

IWANABETHATGUY changed the title ~~fix: 8812~~ fix: use ImportKind::Import for common-chunk root computation Mar 25, 2026

IWANABETHATGUY force-pushed the 03-25-fix_8812 branch 4 times, most recently from c18ded4 to 9f1139c Compare March 26, 2026 14:26

IWANABETHATGUY marked this pull request as ready for review March 26, 2026 14:42

IWANABETHATGUY force-pushed the 03-25-fix_8812 branch from 9f1139c to 7dd60cb Compare March 26, 2026 14:42

IWANABETHATGUY requested review from hyf0 and shulaoda March 27, 2026 03:23

shulaoda approved these changes Mar 27, 2026

View reviewed changes

IWANABETHATGUY force-pushed the 03-25-fix_8812 branch from 7dd60cb to 63774a0 Compare March 27, 2026 03:47

IWANABETHATGUY added the graphite: merge-when-ready label Mar 27, 2026

graphite-app bot force-pushed the 03-25-fix_8812 branch from 63774a0 to 7f454c8 Compare March 27, 2026 03:52

hyf0 approved these changes Mar 27, 2026

View reviewed changes

graphite-app bot merged commit 7f454c8 into main Mar 27, 2026
31 checks passed

graphite-app bot deleted the 03-25-fix_8812 branch March 27, 2026 03:56

graphite-app bot removed the graphite: merge-when-ready label Mar 27, 2026

sapphi-red mentioned this pull request Mar 27, 2026

[VITE 8] Rolldown chunk ordering bug: module-level side effects execute in wrong order within concatenated chunk vitejs/vite#21866

Open

7 tasks

This was referenced Apr 1, 2026

release: v1.0.0-rc.13 #8971

Closed

release: v1.0.0-rc.13 #8984

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: use ImportKind::Import for common-chunk root computation#8899

fix: use ImportKind::Import for common-chunk root computation#8899
graphite-app[bot] merged 1 commit intomainfrom
03-25-fix_8812

IWANABETHATGUY commented Mar 25, 2026 •

edited

Loading

Uh oh!

IWANABETHATGUY commented Mar 25, 2026

Uh oh!

netlify bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Mar 26, 2026

Uh oh!

IWANABETHATGUY commented Mar 27, 2026 •

edited by graphite-app bot

Loading

Uh oh!

hyf0 Mar 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

IWANABETHATGUY commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

IWANABETHATGUY commented Mar 25, 2026

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

codspeed-hq bot commented Mar 26, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

IWANABETHATGUY commented Mar 27, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

hyf0 Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

IWANABETHATGUY commented Mar 25, 2026 •

edited

Loading

netlify bot commented Mar 25, 2026 •

edited

Loading

IWANABETHATGUY commented Mar 27, 2026 •

edited by graphite-app bot

Loading